This is an archive of the discontinued LLVM Phabricator instance.

Differential D92460

[dfsan] Test loading global ptrs
ClosedPublic

Authored by stephan.yichao.zhao on Dec 1 2020, 10:05 PM.

Details

Reviewers
morehouse
Commits
rG838ecf2ea483: [dfsan] Test loading global ptrs
Summary

This covers a branch in the loadShadow method.

Diff Detail

Event Timeline

stephan.yichao.zhao created this revision.Dec 1 2020, 10:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2020, 10:05 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
stephan.yichao.zhao requested review of this revision.Dec 1 2020, 10:05 PM
Harbormaster completed remote builds in B80772: Diff 308873.Dec 1 2020, 10:32 PM
morehouse accepted this revision.Dec 2 2020, 6:30 AM

LGTM

This revision is now accepted and ready to land.Dec 2 2020, 6:30 AM
This revision was landed with ongoing or failed builds.Dec 2 2020, 1:36 PM
Closed by commit rG838ecf2ea483: [dfsan] Test loading global ptrs (authored by Jianzhou Zhao <jianzhouzh@google.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Jianzhou Zhao <jianzhouzh@google.com> added a commit: rG838ecf2ea483: [dfsan] Test loading global ptrs.

Revision Contents

PathSize
llvm/
test/
Instrumentation/
DataFlowSanitizer/
9 lines

Diff 309045

llvm/test/Instrumentation/DataFlowSanitizer/load.ll

Show First 20 Lines • Show All 160 Lines • ▼ Show 20 Linesdefine i64 @load64(i64* %p) {
; NO_COMBINE_PTR_LABEL: call {{.*}} @__dfsan_union_load ; NO_COMBINE_PTR_LABEL: call {{.*}} @__dfsan_union_load
; NO_COMBINE_PTR_LABEL: getelementptr i64, i64* {{.*}} i64 ; NO_COMBINE_PTR_LABEL: getelementptr i64, i64* {{.*}} i64
; NO_COMBINE_PTR_LABEL: load i64, i64* ; NO_COMBINE_PTR_LABEL: load i64, i64*
; NO_COMBINE_PTR_LABEL: icmp eq i64 ; NO_COMBINE_PTR_LABEL: icmp eq i64
%a = load i64, i64* %p %a = load i64, i64* %p
ret i64 %a ret i64 %a
} }
@X = constant i1 1
define i1 @load_global() {
; NO_COMBINE_PTR_LABEL: @"dfs$load_global"
; NO_COMBINE_PTR_LABEL: store i16 0, i16* @__dfsan_retval_tls, align 2
%a = load i1, i1* @X
ret i1 %a
}
No newline at end of file