This is an archive of the discontinued LLVM Phabricator instance.

[scudo][standalone] Add missing va_end() in ScopedString::append
ClosedPublic

Authored by xNombre on Dec 1 2020, 4:31 AM.

Details

Summary

In ScopedString::append va_list ArgsCopy is created but never cleanuped
which can lead to undefined behaviour, like stack corruption.

Diff Detail

Event Timeline

xNombre created this revision.Dec 1 2020, 4:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2020, 4:31 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
xNombre requested review of this revision.Dec 1 2020, 4:31 AM
cryptoad accepted this revision.Dec 1 2020, 7:58 AM

Thank you, good catch!!

This revision is now accepted and ready to land.Dec 1 2020, 7:58 AM

Do you need me to commit this?

This revision was landed with ongoing or failed builds.Dec 2 2020, 4:11 PM
This revision was automatically updated to reflect the committed changes.