This is an archive of the discontinued LLVM Phabricator instance.

Differential D92379

[libcxx] Apply msvcrt specific exception for lgamma() to mingw configurations, too
ClosedPublic

Authored by mstorsjo on Dec 1 2020, 3:40 AM.

Details

Reviewers
amccarth
ldionne
Group Reviewers
Restricted Project
Commits
rG0d7bd72f5ab4: [libcxx] Apply msvcrt specific exception for lgamma() to mingw configurations…
Summary

This fixes linking code that uses bits of the <random> header on mingw targets.

Diff Detail

Event Timeline

mstorsjo created this revision.Dec 1 2020, 3:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2020, 3:40 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
mstorsjo requested review of this revision.Dec 1 2020, 3:40 AM
Harbormaster completed remote builds in B80638: Diff 308609.Dec 1 2020, 4:29 AM
ldionne accepted this revision.Dec 1 2020, 3:47 PM
This revision is now accepted and ready to land.Dec 1 2020, 3:47 PM
Closed by commit rG0d7bd72f5ab4: [libcxx] Apply msvcrt specific exception for lgamma() to mingw configurations… (authored by mstorsjo). · Explain WhyDec 1 2020, 11:55 PM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG0d7bd72f5ab4: [libcxx] Apply msvcrt specific exception for lgamma() to mingw configurations….

Revision Contents

PathSize
libcxx/
include/
4 lines

Diff 308886

libcxx/include/random

Show First 20 Lines • Show All 4,029 Lines • ▼ Show 20 Lines friend _LIBCPP_INLINE_VISIBILITY
const binomial_distribution& __y) const binomial_distribution& __y)
{return __x.__p_ == __y.__p_;} {return __x.__p_ == __y.__p_;}
friend _LIBCPP_INLINE_VISIBILITY friend _LIBCPP_INLINE_VISIBILITY
bool operator!=(const binomial_distribution& __x, bool operator!=(const binomial_distribution& __x,
const binomial_distribution& __y) const binomial_distribution& __y)
{return !(__x == __y);} {return !(__x == __y);}
}; };
#ifndef _LIBCPP_MSVCRT #ifndef _LIBCPP_MSVCRT_LIKE
extern "C" double lgamma_r(double, int *); extern "C" double lgamma_r(double, int *);
#endif #endif
inline _LIBCPP_INLINE_VISIBILITY double __libcpp_lgamma(double __d) { inline _LIBCPP_INLINE_VISIBILITY double __libcpp_lgamma(double __d) {
#if defined(_LIBCPP_MSVCRT) #if defined(_LIBCPP_MSVCRT_LIKE)
return lgamma(__d); return lgamma(__d);
#else #else
int __sign; int __sign;
return lgamma_r(__d, &__sign); return lgamma_r(__d, &__sign);
#endif #endif
} }
template<class _IntType> template<class _IntType>
▲ Show 20 Lines • Show All 2,770 Lines • Show Last 20 Lines