This is an archive of the discontinued LLVM Phabricator instance.

oontvoo retitled this revision from [sanitizer] Disable use_tls_dynamic on on-Android x86 Linux. to [sanitizer] Disable use_tls_dynamic on non-Android x86 Linux..Nov 28 2020, 6:15 PM

Harbormaster completed remote builds in B80437: Diff 308193.Nov 28 2020, 6:40 PM

Harbormaster completed remote builds in B80438: Diff 308194.Nov 28 2020, 6:50 PM

thakis added inline comments.Nov 28 2020, 7:49 PM

compiler-rt/test/lsan/TestCases/Linux/use_tls_dynamic.cpp
13	I think we only want to disable it on 32-bit (non-android) linux -- does `i386-linux && !android` work, to restore the pre D89884 state as much as possible?

s/x86/i386-linux

Harbormaster completed remote builds in B80449: Diff 308211.Nov 29 2020, 6:41 AM

Thanks!

This revision is now accepted and ready to land.Nov 29 2020, 5:58 PM

Closed by commit rG1b723a955da0: [sanitizer] Disable use_tls_dynamic on on-Android x86 Linux. (authored by oontvoo). · Explain WhyNov 30 2020, 8:45 AM

This revision was automatically updated to reflect the committed changes.

oontvoo added a commit: rG1b723a955da0: [sanitizer] Disable use_tls_dynamic on on-Android x86 Linux..

Revision Contents

Path

Size

compiler-rt/

test/

lsan/

TestCases/

Linux/

use_tls_dynamic.cpp

2 lines

Diff 308386

compiler-rt/test/lsan/TestCases/Linux/use_tls_dynamic.cpp

	// Test that dynamically allocated TLS space is included in the root set.			// Test that dynamically allocated TLS space is included in the root set.

	// This is known to be broken with glibc-2.27+ but it should pass with Bionic			// This is known to be broken with glibc-2.27+ but it should pass with Bionic
	// https://bugs.llvm.org/show_bug.cgi?id=37804			// https://bugs.llvm.org/show_bug.cgi?id=37804
	// XFAIL: glibc-2.27			// XFAIL: glibc-2.27

	// RUN: LSAN_BASE="report_objects=1:use_stacks=0:use_registers=0:use_ld_allocations=0"			// RUN: LSAN_BASE="report_objects=1:use_stacks=0:use_registers=0:use_ld_allocations=0"
	// RUN: %clangxx %s -DBUILD_DSO -fPIC -shared -o %t-so.so			// RUN: %clangxx %s -DBUILD_DSO -fPIC -shared -o %t-so.so
	// RUN: %clangxx_lsan %s -o %t			// RUN: %clangxx_lsan %s -o %t
	// RUN: %env_lsan_opts=$LSAN_BASE:"use_tls=0" not %run %t 2>&1 \| FileCheck %s			// RUN: %env_lsan_opts=$LSAN_BASE:"use_tls=0" not %run %t 2>&1 \| FileCheck %s
	// RUN: %env_lsan_opts=$LSAN_BASE:"use_tls=1" %run %t 2>&1			// RUN: %env_lsan_opts=$LSAN_BASE:"use_tls=1" %run %t 2>&1
	// RUN: %env_lsan_opts="" %run %t 2>&1			// RUN: %env_lsan_opts="" %run %t 2>&1
	// UNSUPPORTED: arm,powerpc			// UNSUPPORTED: arm,powerpc,i386-linux && !android
				thakisUnsubmitted Done Reply Inline Actions I think we only want to disable it on 32-bit (non-android) linux -- does `i386-linux && !android` work, to restore the pre D89884 state as much as possible? thakis: I think we only want to disable it on 32-bit (non-android) linux -- does `i386-linux && !

	#ifndef BUILD_DSO			#ifndef BUILD_DSO
	#include <assert.h>			#include <assert.h>
	#include <dlfcn.h>			#include <dlfcn.h>
	#include <stdio.h>			#include <stdio.h>
	#include <stdlib.h>			#include <stdlib.h>
	#include <string>			#include <string>
	#include "sanitizer_common/print_address.h"			#include "sanitizer_common/print_address.h"
	▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Disable use_tls_dynamic on non-Android x86 Linux.ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 308386

compiler-rt/test/lsan/TestCases/Linux/use_tls_dynamic.cpp

[sanitizer] Disable use_tls_dynamic on non-Android x86 Linux.
ClosedPublic