[obj2yaml] - Don't assert when trying to calculate the expected section offset.

[grimar]

Summary

The following line asserts when sh_addralign > MAX_UINT32 && (uint32_t)sh_addralign == 0:

ExpectedOffset = alignTo(ExpectedOffset,
                         SecHdr.sh_addralign ? SecHdr.sh_addralign : 1);

it happens because sh_addralign is truncated to 32-bit value, but alignTo
doesn't accept Align == 0. We should change 1 to 1uLL.

[jhenderson]

I'm rather surprised that this is needed, if I'm honest. Intuitively, I'd expect the result of that ternary to be a uin64_t, since that's the type of sh_addralign, but I guess not. LGTM.

llvm/test/tools/obj2yaml/ELF/offset.yaml

 # BASIC-NEXT:   - Name:         .bar2
 # BASIC-NEXT:     Type:         SHT_PROGBITS
 # BASIC-NEXT:     AddressAlign: 0x10
 # BASIC-NEXT:     Content:      '00'
 # BASIC-NEXT:   - Name:         .bar3
 # BASIC-NEXT:     Type:         SHT_PROGBITS
 # BASIC-NEXT:     AddressAlign: 0x10
 # BASIC-NEXT:     Offset:       0x200
+# BASIC-NEXT:   - Name:         .bar4
+# BASIC-NEXT:     Type:         SHT_PROGBITS
+# BASIC-NEXT:     AddressAlign: 0x100000000
+# BASIC-NEXT:     Offset:       0x210
 
 --- !ELF
 FileHeader:
   Class: ELFCLASS64
   Data:  ELFDATA2LSB
   Type:  ET_REL
 Sections:
 ## The offset of .foo1 by default is 0x40, because it is placed right
- Name:         .bar2
     Size:         1
 ## [Offset of .bar2 + size of .bar2] aligned by 0x10 is not equal to the offset
 ## of .bar3. We dump the "Offset" key in this case.
 ## sh_offset of .bar3 is 0x200.
   - Name:         .bar3
     Type:         SHT_PROGBITS
     AddressAlign: 0x10
     Offset:       0x200
+## A case where AddressAlign > MAX_UINT32 and (uint32_t)AddressAlign == 0.
+## Check we dump an offset in this case properly.
+  - Name:         .bar4
+    Type:         SHT_PROGBITS
+    AddressAlign: 0x100000000
+    Offset:       0x210
 
 ## Show we dump the "Offset" key for the first section when
 ## it has an unexpected file offset.
 
 # RUN: yaml2obj %s -DFIRSTOFF=0x40 -o %t2a.o
 # RUN: obj2yaml %t2a.o | FileCheck %s --check-prefix=BASIC
 # RUN: yaml2obj %s -DFIRSTOFF=0x41 -o %t2b.o
 # RUN: obj2yaml %t2b.o | FileCheck %s --check-prefix=FIRSTSEC

llvm/tools/obj2yaml/elf2yaml.cpp

static void dumpSectionOffsets(const typename ELFT::Ehdr &Header,
   else
     ExpectedOffset = sizeof(typename ELFT::Ehdr);
 
   for (const std::unique_ptr<ELFYAML::Chunk> &C :
        makeArrayRef(V).drop_front()) {
     ELFYAML::Section &Sec = *cast<ELFYAML::Section>(C.get());
     const typename ELFT::Shdr &SecHdr = S[Sec.OriginalSecNdx];
 
-    ExpectedOffset =
-        alignTo(ExpectedOffset, SecHdr.sh_addralign ? SecHdr.sh_addralign : 1);
+    ExpectedOffset = alignTo(ExpectedOffset,
+                             SecHdr.sh_addralign ? SecHdr.sh_addralign : 1uLL);
 
     // We only set the "Offset" field when it can't be naturally derived
     // from the offset and size of the previous section. This reduces
     // the noise in the YAML output.
     if (SecHdr.sh_offset != ExpectedOffset)
       Sec.Offset = (yaml::Hex64)SecHdr.sh_offset;
 
     if (Sec.Type == ELF::SHT_NOBITS &&