This is an archive of the discontinued LLVM Phabricator instance.

[libc++] ADL-proof <variant> by adding _VSTD:: qualification to calls
ClosedPublic

Authored by Quuxplusone on Nov 24 2020, 7:51 AM.

Details

Summary

__invoke_constexpr has been missing its _VSTD:: since the original commit in 0d3d8de014f1012dd0b2c2c077099cf6face44e5.

Diff Detail

Event Timeline

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2020, 7:51 AM
Quuxplusone requested review of this revision.Nov 24 2020, 7:51 AM
ldionne accepted this revision.Nov 24 2020, 8:51 AM

LGTM if CI passes.

This revision is now accepted and ready to land.Nov 24 2020, 8:51 AM

XFAIL the new test for OSX 10.13, the same way as visit.pass.cpp is XFAILed. If this makes CI happy, I'll land it today.