[libc++] ADL-proof <variant> by adding _VSTD:: qualification to calls

[• Quuxplusone]

Summary

__invoke_constexpr has been missing its _VSTD:: since the original commit in 0d3d8de014f1012dd0b2c2c077099cf6face44e5.

[ldionne]

LGTM if CI passes.

[• Quuxplusone]

XFAIL the new test for OSX 10.13, the same way as visit.pass.cpp is XFAILed. If this makes CI happy, I'll land it today.

libcxx/include/variant

static constexpr auto __make_farray(_Fs&&... __fs) {
     return __result{{_VSTD::forward<_Fs>(__fs)...}};
   }
 
   template <std::size_t... _Is>
   struct __dispatcher {
     template <class _Fp, class... _Vs>
     inline _LIBCPP_INLINE_VISIBILITY
     static constexpr decltype(auto) __dispatch(_Fp __f, _Vs... __vs) {
-        return __invoke_constexpr(
+        return _VSTD::__invoke_constexpr(
             static_cast<_Fp>(__f),
             __access::__base::__get_alt<_Is>(static_cast<_Vs>(__vs))...);
     }
   };
 
   template <class _Fp, class... _Vs, size_t... _Is>
   inline _LIBCPP_INLINE_VISIBILITY
   static constexpr auto __make_dispatch(index_sequence<_Is...>) {
private:
   template <class _Visitor>
   struct __value_visitor {
     template <class... _Alts>
     inline _LIBCPP_INLINE_VISIBILITY
     constexpr decltype(auto) operator()(_Alts&&... __alts) const {
       __std_visit_exhaustive_visitor_check<
           _Visitor,
           decltype((_VSTD::forward<_Alts>(__alts).__value))...>();
-      return __invoke_constexpr(_VSTD::forward<_Visitor>(__visitor),
+      return _VSTD::__invoke_constexpr(_VSTD::forward<_Visitor>(__visitor),
                                 _VSTD::forward<_Alts>(__alts).__value...);
     }
     _Visitor&& __visitor;
   };
 
   template <class _Visitor>
   inline _LIBCPP_INLINE_VISIBILITY
   static constexpr auto __make_value_visitor(_Visitor&& __visitor) {

libcxx/test/std/utilities/variant/variant.visit/robust_against_adl.pass.cpp

+// -*- C++ -*-
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++03, c++11, c++14
+
+// Throwing bad_variant_access is supported starting in macosx10.13
+// XFAIL: with_system_cxx_lib=macosx10.12 && !no-exceptions
+// XFAIL: with_system_cxx_lib=macosx10.11 && !no-exceptions
+// XFAIL: with_system_cxx_lib=macosx10.10 && !no-exceptions
+// XFAIL: with_system_cxx_lib=macosx10.9 && !no-exceptions
+
+// <variant>
+// template <class Visitor, class... Variants>
+// constexpr see below visit(Visitor&& vis, Variants&&... vars);
+
+#include <variant>
+
+#include "test_macros.h"
+
+struct Incomplete;
+template<class T> struct Holder { T t; };
+
+constexpr bool test(bool do_it)
+{
+    if (do_it) {
+        std::variant<Holder<Incomplete>*, int> v = nullptr;
+        std::visit([](auto){}, v);
+        std::visit([](auto) -> Holder<Incomplete>* { return nullptr; }, v);
+    }
+    return true;
+}
+
+int main(int, char**)
+{
+    test(true);
+#if TEST_STD_VER > 17
+    static_assert(test(true));
+#endif
+    return 0;
+}