[lld/mac] Don't warn on -bundle and -execute flags

[thakis]

Summary

They've been implemented since D87856 but since they still were
HelpHidden, the driver still warned claiming they were implemented.
Remove HelpHidden.

Use -fatal_warnings to test that the flags now don't warn. The
test depends on D91894 and D91891 to pass.

[int3]

thanks for the fix!

maybe we should make %lld expand to include -fatal_warnings going ahead 🤔

[int3]

Please add lld-macho as the group reviewer in the future, that way more people can help review :)

[thakis]

In D91971#2421936, @int3 wrote:

thanks for the fix!

maybe we should make %lld expand to include -fatal_warnings going ahead 🤔

I tried this and found https://reviews.llvm.org/D87199#2423947 :)

lld/MachO/Options.td

 // and serve as a scoreboard for annotating our progress toward
 // implementing ld64 options in lld. As you add implementions to
 // Driver.cpp, please remove the hidden flag here.
 
 def grp_kind : OptionGroup<"kind">, HelpText<"OUTPUT KIND">;
 
 def execute : Flag<["-"], "execute">,
      HelpText<"Produce a main executable (default)">,
-     Flags<[HelpHidden]>,
      Group<grp_kind>;
 def dylib : Flag<["-"], "dylib">,
      HelpText<"Produce a shared library">,
      Group<grp_kind>;
 def bundle : Flag<["-"], "bundle">,
      HelpText<"Produce a bundle">,
-     Flags<[HelpHidden]>,
      Group<grp_kind>;
 def r : Flag<["-"], "r">,
      HelpText<"Merge multiple object files into one, retaining relocations">,
      Flags<[HelpHidden]>,
      Group<grp_kind>;
 def dylinker : Flag<["-"], "dylinker">,
      HelpText<"Produce a dylinker only used when building dyld">,
      Flags<[HelpHidden]>,

lld/test/MachO/load-commands.s

 # REQUIRES: x86
 # RUN: rm -rf %t && mkdir -p %t
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t/test.o
 # RUN: %lld -o %t/executable %t/test.o
-# RUN: %lld -bundle -o %t/bundle %t/test.o
-# RUN: %lld -dylib -o %t/dylib %t/test.o
+# RUN: %lld -fatal_warnings -execute -o %t/explicit-executable %t/test.o
+# RUN: %lld -fatal_warnings -bundle -o %t/bundle %t/test.o
+# RUN: %lld -fatal_warnings -dylib -o %t/dylib %t/test.o
 
 ## These load commands should be in every final output binary.
 # COMMON-DAG: cmd LC_DYLD_INFO_ONLY
 # COMMON-DAG: cmd LC_SYMTAB
 # COMMON-DAG: cmd LC_DYSYMTAB
 # COMMON-DAG: cmd LC_UUID
 
 ## Check for the presence of load commands that are essential for a working
 ## executable. Also check that it has the right filetype.
 # RUN: llvm-objdump --macho --all-headers %t/executable | FileCheck %s --check-prefix=COMMON
 # RUN: llvm-objdump --macho --all-headers %t/executable | FileCheck %s --check-prefix=EXEC
+# RUN: llvm-objdump --macho --all-headers %t/explicit-executable | FileCheck %s --check-prefix=COMMON
+# RUN: llvm-objdump --macho --all-headers %t/explicit-executable | FileCheck %s --check-prefix=EXEC
 # EXEC:      magic        cputype cpusubtype  caps    filetype
 # EXEC-NEXT: MH_MAGIC_64  X86_64         ALL  {{.*}}  EXECUTE
 # EXEC-DAG:  cmd LC_MAIN
 # EXEC-DAG:  cmd LC_LOAD_DYLINKER
 
 ## Check for the absence of load commands that should not be in an executable.
 # RUN: llvm-objdump --macho --all-headers %t/executable | FileCheck %s --check-prefix=NEXEC
 # NEXEC-NOT: cmd: LC_ID_DYLIB