[llvm-zorg]Give default values to BUILDBOT_CLOBBER and BUILDBOT_REVISION

[oontvoo]

Summary

so you don't have to set them if you don't care about them.

[vitalybuka]

zorg/buildbot/builders/sanitizers/buildbot_functions.sh

23–29

this way is shorter and comment is redundant

[vitalybuka]

zorg/buildbot/builders/sanitizers/buildbot_functions.sh

23–29

off-cause it should be BUILDBOT_REVISION="${BUILDBOT_REVISION:-origin/master}"

[oontvoo]

updated diff

[oontvoo]

zorg/buildbot/builders/sanitizers/buildbot_functions.sh

23–29

Thanks!

zorg/buildbot/builders/sanitizers/buildbot_functions.sh

(
   ccache -s
   echo
   echo "How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild"
   echo
   exit 0
 )
 echo @@@BUILD_STEP Prepare@@@
 
+BUILDBOT_CLOBBER="${BUILDBOT_CLOBBER:-}"
+BUILDBOT_REVISION="${BUILDBOT_REVISION:-origin/master}"
+
 function rm_dirs {
   while ! rm -rf $@ ; do sleep 1; done
 }
 
 function stage1_clobber {
   rm_dirs llvm_build2_* llvm_build_* libcxx_build_* ${STAGE1_CLOBBER:-}
 }
 
 function clobber {
   if [ "$BUILDBOT_CLOBBER" != "" ]; then
     echo @@@BUILD_STEP clobber@@@
     rm_dirs svn_checkout llvm llvm-project llvm_build0 ${CLOBBER:-}
(
         mkdir -p llvm-project
         cd llvm-project
         git init
         git remote add origin https://github.com/llvm/llvm-project.git
       )
       cd llvm-project
       git fetch --depth $DEPTH origin master
       git clean -fd
-      local REV=
-      if [[ "$BUILDBOT_REVISION" == "" ]] ; then
-        REV=origin/master
-      else
-        REV=${BUILDBOT_REVISION}
+      local REV=${BUILDBOT_REVISION}
+      if [[  "$REV" != "origin/master" ]] ; then
         # "git fetch --depth 1 origin $REV" does not work with 2.11 on bots
         while true ; do
           git checkout $REV && break
           git rev-list --pretty --max-count=1 origin/master
           git rev-list --pretty --max-parents=0 origin/master
           echo "DEPTH=$DEPTH is too small"
           [[ "$DEPTH" -le "1000000" ]] || exit 1
           DEPTH=$(( $DEPTH * 10 ))