Page MenuHomePhabricator
Differential D91697

[SystemZ] Use ISD::ABS opcode during isel
ClosedPublic
Actions

Authored by jonpa on Nov 18 2020, 4:06 AM.

Details

Reviewers
uweigand
Commits
rG45b8e37afcf4: [SystemZ] Use ISD::ABS opcode during isel.
Summary

The SystemZISD::IABS node is no longer needed since ISD::ABS can be used instead.

This is nearly NFC on SPEC 2017, but I now see 6 more LPGR:s replacing la/srag/xgr... (3 files changed)

Diff Detail

Event Timeline

jonpa created this revision.Nov 18 2020, 4:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 18 2020, 4:06 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
jonpa requested review of this revision.Nov 18 2020, 4:06 AM
jonpa mentioned this in D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.
uweigand accepted this revision.Nov 18 2020, 5:09 AM

LGTM, thanks!

This revision is now accepted and ready to land.Nov 18 2020, 5:09 AM
lkail added a subscriber: lkail.Nov 18 2020, 5:16 AM
Closed by commit rG45b8e37afcf4: [SystemZ] Use ISD::ABS opcode during isel. (authored by jonpa). · Explain WhyNov 18 2020, 5:45 AM
This revision was automatically updated to reflect the committed changes.
jonpa added a commit: rG45b8e37afcf4: [SystemZ] Use ISD::ABS opcode during isel..

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
SystemZ/
3 lines
6 lines
14 lines
8 lines
23 lines

Diff 306072

View Options

llvm/lib/Target/SystemZ/SystemZISelLowering.h

Loading...
View Options

llvm/lib/Target/SystemZ/SystemZISelLowering.cpp

Loading...
View Options

llvm/lib/Target/SystemZ/SystemZInstrInfo.td

Loading...
View Options

llvm/lib/Target/SystemZ/SystemZInstrVector.td

Loading...
View Options

llvm/lib/Target/SystemZ/SystemZOperators.td

Loading...