Page MenuHomePhabricator

Add utility for testing if we're matching nodes AsIs
ClosedPublic

Authored by steveire on Nov 10 2020, 1:47 AM.

Diff Detail

Event Timeline

steveire created this revision.Nov 10 2020, 1:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2020, 1:47 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
steveire requested review of this revision.Nov 10 2020, 1:47 AM
aaron.ballman accepted this revision.Nov 10 2020, 5:20 AM

LGTM, thanks!

clang/lib/ASTMatchers/ASTMatchersInternal.cpp
195

I don't insist, but I do wonder if we want to inline the definition in the header file rather than put it in the implementation file so that call sites have an easier time inlining the functionality.

This revision is now accepted and ready to land.Nov 10 2020, 5:20 AM
steveire added inline comments.Nov 10 2020, 11:25 AM
clang/lib/ASTMatchers/ASTMatchersInternal.cpp
195

If I inline it I get

error: invalid use of incomplete type ‘class clang::ASTContext’

I think there was a drive at some point to use ASTContext less in header files.

aaron.ballman added inline comments.Nov 10 2020, 11:27 AM
clang/lib/ASTMatchers/ASTMatchersInternal.cpp
195

Thanks for checking!

This revision was landed with ongoing or failed builds.Nov 10 2020, 11:28 AM
This revision was automatically updated to reflect the committed changes.