[libcxx] [test] Make a separate create_directory_symlink helper. NFC.

[mstorsjo]

Summary

This more closely mirrors the public API, instead of using an obscure bool parameter.

[ldionne]

libcxx/test/support/filesystem_test_helper.h

347

Why do we not sanitize the source here?

[mstorsjo]

libcxx/test/support/filesystem_test_helper.h

347

Sanitizing the path here converts it into an absolute one, while I guess it's intentional to keep the symlinks relative.

[ldionne]

LGTM!

libcxx/test/support/filesystem_test_helper.h

347

Right, of course.

libcxx/test/support/filesystem_test_helper.h

#endif
     std::string create_dir(fs::path filename_path) {
         std::string filename = filename_path.string();
         filename = sanitize_path(std::move(filename));
         int ret = utils::mkdir(filename.c_str(), 0777); // rwxrwxrwx mode
         assert(ret == 0);
         return filename;
     }
 
-    std::string create_symlink(fs::path source_path,
+    std::string create_file_dir_symlink(fs::path source_path,
                                         fs::path to_path,
                                         bool sanitize_source = true,
                                         bool is_dir = false) {
         std::string source = source_path.string();
         std::string to = to_path.string();
         if (sanitize_source)
             source = sanitize_path(std::move(source));
         to = sanitize_path(std::move(to));
         int ret = utils::symlink(source.c_str(), to.c_str(), is_dir);
         assert(ret == 0);
         return to;
     }
 
+    std::string create_symlink(fs::path source_path,
+                               fs::path to_path,
+                               bool sanitize_source = true) {
+        return create_file_dir_symlink(source_path, to_path, sanitize_source,
+                                       false);
+    }
+
+    std::string create_directory_symlink(fs::path source_path,
+                                         fs::path to_path,
+                                         bool sanitize_source = true) {
+        return create_file_dir_symlink(source_path, to_path, sanitize_source,
+                                       true);
+    }
+
     std::string create_hardlink(fs::path source_path, fs::path to_path) {
         std::string source = source_path.string();
         std::string to = to_path.string();
         source = sanitize_path(std::move(source));
         to = sanitize_path(std::move(to));
         int ret = utils::link(source.c_str(), to.c_str());
         assert(ret == 0);
         return to;
public:
     static_test_env() {
         env_.create_symlink("dne", "bad_symlink", false);
         env_.create_dir("dir1");
         env_.create_dir("dir1/dir2");
         env_.create_file("dir1/dir2/afile3");
         env_.create_dir("dir1/dir2/dir3");
         env_.create_file("dir1/dir2/dir3/file5");
         env_.create_file("dir1/dir2/file4");
-        env_.create_symlink("dir3", "dir1/dir2/symlink_to_dir3", false, true);
+        env_.create_directory_symlink("dir3", "dir1/dir2/symlink_to_dir3", false);
         env_.create_file("dir1/file1");
         env_.create_file("dir1/file2", 42);
         env_.create_file("empty_file");
         env_.create_file("non_empty_file", 42);
-        env_.create_symlink("dir1", "symlink_to_dir", false, true);
+        env_.create_directory_symlink("dir1", "symlink_to_dir", false);
         env_.create_symlink("empty_file", "symlink_to_empty_file", false);
     }
 
     const fs::path Root = env_.test_root;
 
     fs::path makePath(fs::path const& p) const {
         // env_path is expected not to contain symlinks.
         fs::path const& env_path = Root;