This is an archive of the discontinued LLVM Phabricator instance.

[crashlog] Move crash log parsing into its own class
ClosedPublic

Authored by JDevlieghere on Nov 2 2020, 8:27 PM.

Details

Summary

Move crash log parsing out of the CrashLog class and into its own class.

Diff Detail

Event Timeline

JDevlieghere requested review of this revision.Nov 2 2020, 8:27 PM
JDevlieghere created this revision.
JDevlieghere added reviewers: kastiglione, clayborg.
clayborg accepted this revision.Nov 2 2020, 8:56 PM

Looks good, just fix typo I mentioned in inlined comments.

lldb/examples/python/crashlog.py
707

crash_log_parser

708

or this line can be:

crash_log = CrashLogParser(crash_log_file, options.verbose).parse()
This revision is now accepted and ready to land.Nov 2 2020, 8:56 PM
clayborg added inline comments.Nov 2 2020, 8:58 PM
lldb/examples/python/crashlog.py
708

might be nice to test this somehow since this would have failed has this change gone through.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2020, 9:04 AM