Page MenuHomePhabricator

[llvm-exegesis] Do not silently fail on unknown instruction encoding formats.
ClosedPublic

Authored by courbet on Oct 28 2020, 1:30 AM.

Details

Summary

The addition of TILELOADD instructions with a new encoding format
triggered a hard abort instead of proper error reporting due to the use
of llvm_unreachable for actually reachable code.
Properly report an error when the encoding format is unknown.

Diff Detail

Event Timeline

courbet created this revision.Oct 28 2020, 1:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2020, 1:30 AM
Herald added a subscriber: mstojanovic. · View Herald Transcript
courbet requested review of this revision.Oct 28 2020, 1:30 AM
gchatelet accepted this revision.Oct 28 2020, 1:52 AM
This revision is now accepted and ready to land.Oct 28 2020, 1:52 AM
This revision was landed with ongoing or failed builds.Oct 28 2020, 2:07 AM
This revision was automatically updated to reflect the committed changes.