This is an archive of the discontinued LLVM Phabricator instance.

[TestPluginCommands] Add skipIfGcc at the right place.
ClosedPublic

Authored by sivachandra on Apr 13 2015, 5:06 PM.

Details

Summary

The decorator @expectedFailureGcc was at the wrong place skipping this
test all together. This patch removes it and adds skipIfGcc at the right
place.

Diff Detail

Event Timeline

sivachandra retitled this revision from to [TestPluginCommands] Add skipIfGcc at the right place..
sivachandra updated this object.
sivachandra edited the test plan for this revision. (Show Details)
sivachandra added reviewers: chying, chaoren.
sivachandra added a subscriber: Unknown Object (MLST).
chaoren accepted this revision.Apr 13 2015, 5:14 PM
chaoren edited edge metadata.

LGTM, I'll look into the crash, and change it to xfail if I can fix it.

This revision is now accepted and ready to land.Apr 13 2015, 5:14 PM
sivachandra closed this revision.Apr 13 2015, 5:16 PM