This is an archive of the discontinued LLVM Phabricator instance.

Remove unnecessary code
Needs ReviewPublic

Authored by AlFadeev on Oct 21 2020, 8:00 AM.

Reviewers

zturner

Summary

Remove unnecessary code in CommandLine.cpp

	Time	Test
	390 ms	linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
	470 ms	windows > lld.ELF/invalid::symtab-sh-info.s

AlFadeev requested review of this revision.Oct 21 2020, 8:00 AM

Path

Size

llvm/

lib/

Support/

3 lines

Show First 20 Lines • Show All 526 Lines • ▼ Show 20 Lines	Option *CommandLineParser::LookupOption(SubCommand &Sub, StringRef &Arg,
assert(&Sub != &*AllSubCommands);		assert(&Sub != &*AllSubCommands);

size_t EqualPos = Arg.find('=');		size_t EqualPos = Arg.find('=');

// If we have an equals sign, remember the value.		// If we have an equals sign, remember the value.
if (EqualPos == StringRef::npos) {		if (EqualPos == StringRef::npos) {
// Look up the option.		// Look up the option.
auto I = Sub.OptionsMap.find(Arg);		auto I = Sub.OptionsMap.find(Arg);
if (I == Sub.OptionsMap.end())
return nullptr;

return I != Sub.OptionsMap.end() ? I->second : nullptr;		return I != Sub.OptionsMap.end() ? I->second : nullptr;
}		}

// If the argument before the = is a valid option name and the option allows		// If the argument before the = is a valid option name and the option allows
// non-prefix form (ie is not AlwaysPrefix), we match. If not, signal match		// non-prefix form (ie is not AlwaysPrefix), we match. If not, signal match
// failure by returning nullptr.		// failure by returning nullptr.
auto I = Sub.OptionsMap.find(Arg.substr(0, EqualPos));		auto I = Sub.OptionsMap.find(Arg.substr(0, EqualPos));
if (I == Sub.OptionsMap.end())		if (I == Sub.OptionsMap.end())
▲ Show 20 Lines • Show All 2,063 Lines • Show Last 20 Lines