This is an archive of the discontinued LLVM Phabricator instance.

Differential D89704

[libc++] Skip tests using constexpr constructors with older clang versions
ClosedPublic

Authored by arichardson on Oct 19 2020, 8:20 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG8041f13e62ae: [libc++] Skip tests using constexpr destructors with older clang versions
Summary

It appears that the released version of clang that supports constexpr
destructors is clang 10 and the oldest one that accepts -std=c++2a is 5,
so mark these as UNSUPPORTED for clang-5 to clang-9.

Diff Detail

Event Timeline

arichardson created this revision.Oct 19 2020, 8:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2020, 8:20 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, dexonsmith. · View Herald Transcript
arichardson requested review of this revision.Oct 19 2020, 8:20 AM
Harbormaster completed remote builds in B75542: Diff 299063.Oct 19 2020, 8:21 AM
arichardson updated this revision to Diff 299066.Oct 19 2020, 8:25 AM

fix typo in comment

Harbormaster completed remote builds in B75543: Diff 299066.Oct 19 2020, 8:27 AM
ldionne accepted this revision.Oct 19 2020, 8:32 AM
This revision is now accepted and ready to land.Oct 19 2020, 8:32 AM
Closed by commit rG8041f13e62ae: [libc++] Skip tests using constexpr destructors with older clang versions (authored by arichardson). · Explain WhyOct 19 2020, 9:23 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG8041f13e62ae: [libc++] Skip tests using constexpr destructors with older clang versions.

Revision Contents

PathSize
libcxx/
test/
std/
utilities/
memory/
specialized.algorithms/
specialized.construct/
2 lines
specialized.destroy/
2 lines
2 lines
2 lines

Diff 299079

libcxx/test/std/utilities/memory/specialized.algorithms/specialized.construct/construct_at.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14, c++17 // UNSUPPORTED: c++03, c++11, c++14, c++17
// constexpr destructors are only supported starting with clang 10
// UNSUPPORTED: clang-5, clang-6, clang-7, clang-8, clang-9
// Investigation needed // Investigation needed
// UNSUPPORTED: gcc // UNSUPPORTED: gcc
// <memory> // <memory>
// template <class T, class ...Args> // template <class T, class ...Args>
// constexpr T* construct_at(T* location, Args&& ...args); // constexpr T* construct_at(T* location, Args&& ...args);
▲ Show 20 Lines • Show All 98 Lines • Show Last 20 Lines

libcxx/test/std/utilities/memory/specialized.algorithms/specialized.destroy/destroy.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14 // UNSUPPORTED: c++03, c++11, c++14
// constexpr destructors are only supported starting with clang 10
// UNSUPPORTED: clang-5, clang-6, clang-7, clang-8, clang-9
// <memory> // <memory>
// template <class ForwardIt> // template <class ForwardIt>
// constexpr void destroy(ForwardIt, ForwardIt); // constexpr void destroy(ForwardIt, ForwardIt);
#include <memory> #include <memory>
#include <cassert> #include <cassert>
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines

libcxx/test/std/utilities/memory/specialized.algorithms/specialized.destroy/destroy_at.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14 // UNSUPPORTED: c++03, c++11, c++14
// constexpr destructors are only supported starting with clang 10
// UNSUPPORTED: clang-5, clang-6, clang-7, clang-8, clang-9
// <memory> // <memory>
// template <class T> // template <class T>
// constexpr void destroy_at(T*); // constexpr void destroy_at(T*);
#include <memory> #include <memory>
#include <cassert> #include <cassert>
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines

libcxx/test/std/utilities/memory/specialized.algorithms/specialized.destroy/destroy_n.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14 // UNSUPPORTED: c++03, c++11, c++14
// constexpr destructors are only supported starting with clang 10
// UNSUPPORTED: clang-5, clang-6, clang-7, clang-8, clang-9
// <memory> // <memory>
// template <class ForwardIt, class Size> // template <class ForwardIt, class Size>
// constexpr ForwardIt destroy_n(ForwardIt, Size s); // constexpr ForwardIt destroy_n(ForwardIt, Size s);
#include <memory> #include <memory>
#include <cassert> #include <cassert>
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines