This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Mark tests for to_time_t as libcpp specific
AbandonedPublic

Authored by mstorsjo on Oct 19 2020, 2:50 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Summary

libstdc++ on linux doesn't provide it; I'm a bit unsure how to navigate all the overloads in the documentation to see whether it really is mandated or not.

Diff Detail

Event Timeline

mstorsjo created this revision.Oct 19 2020, 2:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2020, 2:50 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
mstorsjo requested review of this revision.Oct 19 2020, 2:50 AM
ldionne added inline comments.
libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp
388

I think you're right, it's only specified as a member of system_clock. @EricWF is there a reason why you provided it to_time_t for your _FilesystemClock?

ldionne accepted this revision.Oct 28 2021, 1:43 PM

This LGTM cause we're not supposed to provide to_time_t for the filesystem clock, but @mstorsjo would you mind trying to remove to_time_t from _FilesystemClock completely to see if that breaks anything serious?

This revision is now accepted and ready to land.Oct 28 2021, 1:43 PM
mstorsjo abandoned this revision.Nov 4 2021, 1:27 AM

Superseded by D113027.