This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Allow fs::permissions(path, perms, perm_options, error_code) to be noexcept
ClosedPublic

Authored by mstorsjo on Oct 19 2020, 2:49 AM.

Details

Summary

The standard doesn't declare this overload as noexcept, but doesn't either say that it strictly cannot be noexcept either. The function doesn't throw on errors that are signaled via error_code, but the standard says that it may throw a bad_alloc.

This fixes an error with libstdc++ on linux.

Diff Detail

Event Timeline

mstorsjo created this revision.Oct 19 2020, 2:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2020, 2:49 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
mstorsjo requested review of this revision.Oct 19 2020, 2:49 AM
ldionne accepted this revision.Oct 19 2020, 5:30 AM
This revision is now accepted and ready to land.Oct 19 2020, 5:30 AM