This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Mark tests that require specific allocation behaviours as libcpp only
ClosedPublic

Authored by mstorsjo on Oct 19 2020, 2:46 AM.

Details

Summary

This fixes/silences a few failures on libstdc++ on linux.

Or does the standard actually mandate these strict allocation behaviours here, and libstdc++ violates the standard in this aspect?

Diff Detail

Event Timeline

mstorsjo created this revision.Oct 19 2020, 2:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2020, 2:46 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
mstorsjo requested review of this revision.Oct 19 2020, 2:46 AM
ldionne requested changes to this revision.Oct 19 2020, 5:35 AM
ldionne added a subscriber: ldionne.
ldionne added inline comments.
libcxx/test/std/input.output/filesystems/class.path/path.member/path.native.obs/string_alloc.pass.cpp
9–10

It's a nit, but can you please instead use // REQUIRES: libc++ above the c++03 requirement -- I find it easier to read that way.

This revision now requires changes to proceed.Oct 19 2020, 5:35 AM
mstorsjo updated this revision to Diff 299024.Oct 19 2020, 5:46 AM

Using REQUIRES: libc++ instead of UNSUPPORTED: !libc++.

ldionne accepted this revision.Oct 19 2020, 5:51 AM
This revision is now accepted and ready to land.Oct 19 2020, 5:51 AM