This is an archive of the discontinued LLVM Phabricator instance.

Differential D89256

[LLDB] Fix 37 tests on Windows
ClosedPublic

Authored by amccarth on Oct 12 2020, 11:03 AM.

Download Raw Diff

Details

Reviewers

JDevlieghere

Commits

rGf21fcccef719: [LLDB] Fix 37 tests on Windows

Summary

A Windows-style LLDB_PYTHON_HOME path in a Cmake template didn't have the backslashes escaped, which led to a garbled paths derived from it. Fixed by expanding the environment variable as a raw string literal.

Diff Detail

Event Timeline

amccarth created this revision.Oct 12 2020, 11:03 AM

Herald added a subscriber: mgorny. · View Herald TranscriptOct 12 2020, 11:03 AM

amccarth requested review of this revision.Oct 12 2020, 11:03 AM

LGTM

This revision is now accepted and ready to land.Oct 12 2020, 11:04 AM

Closed by commit rGf21fcccef719: [LLDB] Fix 37 tests on Windows (authored by amccarth). · Explain WhyOct 12 2020, 11:15 AM

This revision was automatically updated to reflect the committed changes.

amccarth added a commit: rGf21fcccef719: [LLDB] Fix 37 tests on Windows.

Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2020, 11:15 AM

Revision Contents

Path

Size

lldb/

include/

lldb/

Host/

Config.h.cmake

2 lines

Diff 297641

lldb/include/lldb/Host/Config.h.cmake

	Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
	#cmakedefine01 LLDB_ENABLE_LIBXML2			#cmakedefine01 LLDB_ENABLE_LIBXML2

	#cmakedefine01 LLDB_ENABLE_LUA			#cmakedefine01 LLDB_ENABLE_LUA

	#cmakedefine01 LLDB_ENABLE_PYTHON			#cmakedefine01 LLDB_ENABLE_PYTHON

	#cmakedefine01 LLDB_EMBED_PYTHON_HOME			#cmakedefine01 LLDB_EMBED_PYTHON_HOME

	#cmakedefine LLDB_PYTHON_HOME "${LLDB_PYTHON_HOME}"			#cmakedefine LLDB_PYTHON_HOME R"(${LLDB_PYTHON_HOME})"

	#define LLDB_LIBDIR_SUFFIX "${LLVM_LIBDIR_SUFFIX}"			#define LLDB_LIBDIR_SUFFIX "${LLVM_LIBDIR_SUFFIX}"

	#endif // #ifndef LLDB_HOST_CONFIG_H			#endif // #ifndef LLDB_HOST_CONFIG_H