This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Fill Watch/AppleTV simulator gaps in PlatformDarwin
ClosedPublic

Authored by teemperor on Oct 9 2020, 2:08 AM.

Details

Summary

When running the test suite against the Watch/AppleTV simulator we currently hitting
the unimplemented parts of PlatformDarwin for the respective simulator platforms.

This just adds the respective switch cases.

This whole code path depends on having a valid Target, so can't just unittest this code
without refactoring it. So instead this is tested by just running the testsuite against
the respective simulators (which is how I found this).

Diff Detail

Event Timeline

teemperor requested review of this revision.Oct 9 2020, 2:08 AM
teemperor created this revision.
teemperor retitled this revision from [lldb] Add Watch/AppleTV simulator to PlatformDarwin to [lldb] Fill Watch/AppleTV simulator gaps in PlatformDarwin.
teemperor added a project: Restricted Project.Oct 12 2020, 10:39 AM
aprantl accepted this revision.Oct 12 2020, 11:02 AM

This trivially LGTM, but we should think about moving this into XcodeSDK.

This revision is now accepted and ready to land.Oct 12 2020, 11:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2020, 6:07 AM