This is an archive of the discontinued LLVM Phabricator instance.

Differential D88744

[lld] Initialize loadThunkSym to nullptr
AbandonedPublic

Authored by aeubanks on Oct 2 2020, 10:12 AM.

Details

Reviewers
rnk
ajpaverd
theraven

Diff Detail

Event Timeline

aeubanks created this revision.Oct 2 2020, 10:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 2 2020, 10:12 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks requested review of this revision.Oct 2 2020, 10:12 AM
aeubanks abandoned this revision.Oct 2 2020, 10:13 AM
aeubanks mentioned this in D87544: [CFGuard] Add address-taken IAT tables and delay-load support.

I forgot this was on top of https://reviews.llvm.org/D87544, ignore this

Harbormaster completed remote builds in B73806: Diff 295859.Oct 2 2020, 10:21 AM

Revision Contents

PathSize
lld/
COFF/
3 lines

Diff 295859

lld/COFF/Symbols.h

Show First 20 Lines • Show All 321 Lines • ▼ Show 20 Lines
// This class represents a symbol imported from a DLL. This has two // This class represents a symbol imported from a DLL. This has two
// names for internal use and external use. The former is used for // names for internal use and external use. The former is used for
// name resolution, and the latter is used for the import descriptor // name resolution, and the latter is used for the import descriptor
// table in an output. The former has "__imp_" prefix. // table in an output. The former has "__imp_" prefix.
class DefinedImportData : public Defined { class DefinedImportData : public Defined {
public: public:
DefinedImportData(StringRef n, ImportFile *f) DefinedImportData(StringRef n, ImportFile *f)
: Defined(DefinedImportDataKind, n), file(f) { : Defined(DefinedImportDataKind, n), file(f), loadThunkSym(nullptr) {}
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: member initializer 'loadThunkSym' does not name a non-static data member or base class [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: member initializer 'loadThunkSym' does not name a non-static data member or…
}
static bool classof(const Symbol *s) { static bool classof(const Symbol *s) {
return s->kind() == DefinedImportDataKind; return s->kind() == DefinedImportDataKind;
} }
uint64_t getRVA() { return file->location->getRVA(); } uint64_t getRVA() { return file->location->getRVA(); }
Chunk *getChunk() { return file->location; } Chunk *getChunk() { return file->location; }
void setLocation(Chunk *addressTable) { file->location = addressTable; } void setLocation(Chunk *addressTable) { file->location = addressTable; }
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines