Drop std::move() calls in places where there's no actual moving
happing, and only the "bugprone-use-after-move" clang-tidy
warning is triggered.
Details
Details
- Reviewers
lhames
Diff Detail
Diff Detail
Unit Tests
Unit Tests
Time | Test | |
---|---|---|
24,680 ms | linux > LLVM.Bindings/Go::go.test |
Event Timeline
Comment Actions
@lhames - I uploaded this change before seeing your reply on GitHub: https://github.com/llvm/llvm-project/pull/250 . I'm fine with abandoning this if you're saying this will be fixed anyway - just let me know. Thanks.
Comment Actions
Hi @emaxx,
Yes, please go ahead and abandon this review -- it will be fixed as soon as the orcv1-removal patch lands. Thank you for the contribution though!
Regards,
Lang.