This is an archive of the discontinued LLVM Phabricator instance.

Fix useless move() in IRCompileLayer.h
AbandonedPublic

Authored by emaxx on Sep 25 2020, 4:01 PM.

Details

Reviewers
lhames
Summary

Drop std::move() calls in places where there's no actual moving
happing, and only the "bugprone-use-after-move" clang-tidy
warning is triggered.

Diff Detail

Unit TestsFailed

Event Timeline

emaxx created this revision.Sep 25 2020, 4:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2020, 4:01 PM
emaxx requested review of this revision.Sep 25 2020, 4:01 PM
emaxx added a comment.Sep 28 2020, 8:42 AM

@lhames - I uploaded this change before seeing your reply on GitHub: https://github.com/llvm/llvm-project/pull/250 . I'm fine with abandoning this if you're saying this will be fixed anyway - just let me know. Thanks.

lhames added a comment.Oct 6 2020, 8:03 PM

Hi @emaxx,

Yes, please go ahead and abandon this review -- it will be fixed as soon as the orcv1-removal patch lands. Thank you for the contribution though!

Regards,
Lang.

emaxx abandoned this revision.Oct 6 2020, 8:07 PM

Abandoning as per comment from @lhames.