Page MenuHomePhabricator

[intel-pt] Refactor the JSON parsing
ClosedPublic

Authored by wallace on Sep 24 2020, 3:15 PM.

Details

Summary

Recently https://reviews.llvm.org/D88103 introduced a nice API for
converting a JSON object into C++ types, which include nice error
messaging.

I'm using that new functioniality to perform the parsing in a much more
elegant way. As a result, the code looks simpler and more maintainable,
as we aren't parsing anymore individual fields manually.

I updated the test cases accordingly.

Diff Detail

Event Timeline

wallace created this revision.Sep 24 2020, 3:15 PM
Herald added a project: Restricted Project. · View Herald Transcript
wallace requested review of this revision.Sep 24 2020, 3:15 PM
clayborg accepted this revision.Sep 24 2020, 3:26 PM
This revision is now accepted and ready to land.Sep 24 2020, 3:26 PM
This revision was landed with ongoing or failed builds.Sep 24 2020, 4:35 PM
This revision was automatically updated to reflect the committed changes.