This is an archive of the discontinued LLVM Phabricator instance.

[scudo/standalone] Fix undefined behavior in checksum test
ClosedPublic

Authored by mcgrathr on Sep 19 2020, 11:43 AM.

Details

Summary

1U has type unsigned int, and << of 32 or more is undefined behavior.
Use the proper type in the lhs of the shift.

Diff Detail

Event Timeline

mcgrathr created this revision.Sep 19 2020, 11:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 19 2020, 11:43 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
mcgrathr requested review of this revision.Sep 19 2020, 11:43 AM
mcgrathr updated this revision to Diff 292982.

formatting

cryptoad accepted this revision.Sep 19 2020, 11:46 AM
This revision is now accepted and ready to land.Sep 19 2020, 11:46 AM
This revision was landed with ongoing or failed builds.Sep 19 2020, 12:28 PM
This revision was automatically updated to reflect the committed changes.