[asan][test] Disable malloc-no-intercept.c on Solaris

[ro]

Summary

TestCases/malloc-no-intercept.c FAILs on Solaris/x86, e.g. with -Dtestfunc=mallinfo:

/usr/bin/ld: /tmp/malloc-no-intercept-586529.o: in function `main':
/vol/llvm/src/llvm-project/dist/compiler-rt/test/asan/TestCases/malloc-no-intercept.c:30: undefined reference to `nonexistent_function'
clang-12: error: linker command failed with exit code 1 (use -v to see invocation)

This is not surprising, actually:

• mallinfo and mallopt only exist in libmalloc
• pvalloc doesn't exist all all
• cfree does exist in libc, but isn't declared in any public header and the OpenSolaris sources reveal that it has a different signature than on Linux
• only memalign is a public interface

To avoid this, this patch disables the interceptors for all but meminfo. Additionally, the test is marked UNSUPPORTED on Solaris since the memalign and cfree variants do link on Solaris.

Tested on amd64-pc-solaris2.11.

It seems a bit weird that for this apparently glibc-only group of interfaces every non-glibc target not only has to analyze the failure, but opt out of the interceptors. It would feel way more natural the other way round: opt-in for known users only.

[vitalybuka]

compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h

504

please clang-format this part

[ro]

compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h

504

I had done so, however at that point the LLVM 10 clang-format
was in my PATH. Fixed now.

compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h

 #define SANITIZER_INTERCEPT_UTMPX \
   (SI_LINUX_NOT_ANDROID || SI_MAC || SI_FREEBSD || SI_NETBSD)
 
 #define SANITIZER_INTERCEPT_GETLOADAVG \
   (SI_LINUX_NOT_ANDROID || SI_MAC || SI_FREEBSD || SI_NETBSD || SI_OPENBSD)
 
 #define SANITIZER_INTERCEPT_MMAP SI_POSIX
 #define SANITIZER_INTERCEPT_MMAP64 SI_LINUX_NOT_ANDROID
-#define SANITIZER_INTERCEPT_MALLOPT_AND_MALLINFO \
+#define SANITIZER_INTERCEPT_MALLOPT_AND_MALLINFO                            \
   (!SI_FREEBSD && !SI_MAC && !SI_NETBSD && !SI_OPENBSD && SI_NOT_FUCHSIA && \
-  SI_NOT_RTEMS)
-#define SANITIZER_INTERCEPT_MEMALIGN \
+   SI_NOT_RTEMS && !SI_SOLARIS)
+#define SANITIZER_INTERCEPT_MEMALIGN                                      \
   (!SI_FREEBSD && !SI_MAC && !SI_NETBSD && !SI_OPENBSD && SI_NOT_RTEMS)
-#define SANITIZER_INTERCEPT_PVALLOC \
+#define SANITIZER_INTERCEPT_PVALLOC                                         \
   (!SI_FREEBSD && !SI_MAC && !SI_NETBSD && !SI_OPENBSD && SI_NOT_FUCHSIA && \
-  SI_NOT_RTEMS)
-#define SANITIZER_INTERCEPT_CFREE \
+   SI_NOT_RTEMS && !SI_SOLARIS)
+#define SANITIZER_INTERCEPT_CFREE                                           \
   (!SI_FREEBSD && !SI_MAC && !SI_NETBSD && !SI_OPENBSD && SI_NOT_FUCHSIA && \
-  SI_NOT_RTEMS)
+   SI_NOT_RTEMS && !SI_SOLARIS)
 #define SANITIZER_INTERCEPT_REALLOCARRAY SI_POSIX
 #define SANITIZER_INTERCEPT_ALIGNED_ALLOC (!SI_MAC && SI_NOT_RTEMS)
 #define SANITIZER_INTERCEPT_MALLOC_USABLE_SIZE \
   (!SI_MAC && !SI_OPENBSD && !SI_NETBSD)
 #define SANITIZER_INTERCEPT_MCHECK_MPROBE SI_LINUX_NOT_ANDROID
 #define SANITIZER_INTERCEPT_WCSCAT SI_POSIX
 #define SANITIZER_INTERCEPT_WCSDUP SI_POSIX
 #define SANITIZER_INTERCEPT_SIGNAL_AND_SIGACTION (!SI_WINDOWS && SI_NOT_FUCHSIA)

compiler-rt/test/asan/TestCases/malloc-no-intercept.c

 // Test that on non-glibc platforms, a number of malloc-related functions are
 // not intercepted.
 
 // RUN: not %clang_asan -Dtestfunc=mallinfo %s -o %t
 // RUN: not %clang_asan -Dtestfunc=mallopt  %s -o %t
 // RUN: not %clang_asan -Dtestfunc=memalign %s -o %t
 // RUN: not %clang_asan -Dtestfunc=pvalloc  %s -o %t
 // RUN: not %clang_asan -Dtestfunc=cfree    %s -o %t
 
 // Conflicts with BIONIC declarations.
 // UNSUPPORTED: android
+// Lacks mallinfo, mallopt except in libmalloc.  cfree with different
+// signature in libc.
+// UNSUPPORTED: solaris
 
 // Inhibit conflicting declaration of memalign on Solaris.
 #if defined(__sun__) && defined(__svr4__)
 #undef __EXTENSIONS__
 #endif
 
 #include <stdlib.h>