This is an archive of the discontinued LLVM Phabricator instance.

[SyntaxTree] Test for '\' inside token.
ClosedPublic

Authored by eduucaldas on Sep 18 2020, 2:42 AM.

Diff Detail

Event Timeline

eduucaldas created this revision.Sep 18 2020, 2:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 18 2020, 2:42 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
eduucaldas requested review of this revision.Sep 18 2020, 2:42 AM
gribozavr2 accepted this revision.Sep 18 2020, 4:36 AM
gribozavr2 added inline comments.
clang/unittests/Tooling/Syntax/BuildTreeTest.cpp
173

That looks like the wrong slash to me (forward instead of backward).

To avoid possible confusion with line continuations in the source file itself, I'd suggest to write it as a regular string literal:

"in\\t a;"

This revision is now accepted and ready to land.Sep 18 2020, 4:36 AM
This revision was landed with ongoing or failed builds.Sep 20 2020, 11:56 PM
This revision was automatically updated to reflect the committed changes.