[flang] Do not dereference an array out of bound just to take its address

[serge-sans-paille]

Summary

This is UB by the standard, and caught by the libstdc++ asserts

[klausler]

LGTM; thanks for fixing this.

flang/lib/Parser/token-sequence.cpp

 }
 
 TokenSequence &TokenSequence::ToLowerCase() {
   std::size_t tokens{start_.size()};
   std::size_t chars{char_.size()};
   std::size_t atToken{0};
   for (std::size_t j{0}; j < chars;) {
     std::size_t nextStart{atToken + 1 < tokens ? start_[++atToken] : chars};
-    char *p{&char_[j]}, *limit{&char_[nextStart]};
+    char *p{&char_[j]};
+    char const *limit{char_.data() + nextStart};
     j = nextStart;
     if (IsDecimalDigit(*p)) {
       while (p < limit && IsDecimalDigit(*p)) {
         ++p;
       }
       if (p >= limit) {
       } else if (*p == 'h' || *p == 'H') {
         // Hollerith