This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Disable failing test for no-exceptions build
ClosedPublic

Authored by ostannard on Sep 15 2020, 3:44 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG2744c2e29572: [libcxx] Disable failing test for no-exceptions build
Summary

This test tries to create a 2 GiB std::string, catching the bad_alloc exception if the allocation fails. However, for no-exceptions builds there is no way for the error to be reported, so this crashes with a null pointer dereference.

Diff Detail

Event Timeline

ostannard created this revision.Sep 15 2020, 3:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2020, 3:44 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ostannard requested review of this revision.Sep 15 2020, 3:44 AM
ldionne accepted this revision.Sep 15 2020, 4:59 AM

Please add a comment explaining why it's disabled for no-exceptions, and commit. It's far from obvious.

This revision is now accepted and ready to land.Sep 15 2020, 4:59 AM
This revision was landed with ongoing or failed builds.Sep 15 2020, 6:28 AM
This revision was automatically updated to reflect the committed changes.