Page MenuHomePhabricator

[lld-macho] In the context of relocs, s/target/referent/ for sections & symbols
ClosedPublic

Authored by gkm on Sep 12 2020, 11:42 PM.

Details

Summary

The word "target" is overloaded, so lighten its load by using another word to denote the symbol or section to which a reloc points. While more stilted than "target", "referent" is rather less pompous than "designatum" or "denotatum". :P

Along the way, make a few neighboring variable names more descriptive.

Diff Detail

Event Timeline

gkm created this revision.Sep 12 2020, 11:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2020, 11:42 PM
gkm requested review of this revision.Sep 12 2020, 11:42 PM
gkm added a reviewer: Restricted Project.Sep 12 2020, 11:43 PM
gkm edited the summary of this revision. (Show Details)
int3 accepted this revision.Sep 15 2020, 6:03 PM
int3 added a subscriber: int3.
int3 added inline comments.
lld/MachO/Writer.cpp
316 ↗(On Diff #291442)

IMO s or sym is fine here, there's no confusion about what it's referring to within the body of this method

This revision is now accepted and ready to land.Sep 15 2020, 6:03 PM
This revision was automatically updated to reflect the committed changes.
gkm marked an inline comment as done.