Page MenuHomePhabricator

[llvm-rc] Allow omitting components from VERSIONINFO version numbers
ClosedPublic

Authored by mstorsjo on Sep 12 2020, 2:27 PM.

Details

Summary

MS rc.exe doesn't require specifying all 4 components.

Diff Detail

Event Timeline

mstorsjo created this revision.Sep 12 2020, 2:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2020, 2:27 PM
mstorsjo requested review of this revision.Sep 12 2020, 2:27 PM
amccarth accepted this revision.Sep 15 2020, 8:48 AM

LGTM.

I never realized rc.exe would accept having too few values for a FILEVERSION or PRODUCTVERSION. The documentation implies that you must provide four components--it is the _fixed_ portion of the VERSIONINFO after all. Not that it matters; this looks harmless.

This revision is now accepted and ready to land.Sep 15 2020, 8:48 AM