This is an archive of the discontinued LLVM Phabricator instance.

[gn] Remove unneeded MC dep from llvm-tblgen
ClosedPublic

Authored by rnk on Sep 11 2020, 5:48 PM.

Details

Summary

Tablegen does not have link time dependencies on MC. Having llvm-tblgen
depend on it causes it to be rebuilt in the gn build every time somebody
touches any cpp file in llvm/lib/MC* or llvm/lib/DebugInfo/Codeview*.
Touching tablegen invalidates most of the rest of the build, and
re-running it takes a while. This is is annoying for me when swapping
between branches that touch CodeView logic.

This dep was added to LLVMBuild.txt back in 2018, and presumably it was
carried over into the gn build.

Diff Detail

Event Timeline

rnk created this revision.Sep 11 2020, 5:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 11 2020, 5:48 PM
rnk requested review of this revision.Sep 11 2020, 5:48 PM
dblaikie accepted this revision.Sep 11 2020, 6:27 PM

Sounds good to me

This revision is now accepted and ready to land.Sep 11 2020, 6:27 PM
This revision was landed with ongoing or failed builds.Sep 11 2020, 6:29 PM
This revision was automatically updated to reflect the committed changes.