This is an archive of the discontinued LLVM Phabricator instance.

Thread safety analysis: Document how try-acquire is handled
ClosedPublic

Authored by aaronpuchert on Sep 2 2020, 5:55 PM.

Details

Summary

I don't think this is obvious, since try-acquire seemingly contradicts
our usual requirements of "no conditional locking".

Diff Detail

Event Timeline

aaronpuchert created this revision.Sep 2 2020, 5:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2020, 5:55 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaronpuchert requested review of this revision.Sep 2 2020, 5:55 PM
aaron.ballman accepted this revision.Sep 3 2020, 6:49 AM

LGTM, thank you for documenting this, that would be confusing without spelling it out explicitly.

This revision is now accepted and ready to land.Sep 3 2020, 6:49 AM