This is an archive of the discontinued LLVM Phabricator instance.

Differential D86763

Remove produce metadata in RewriteModernObjC::RewriteObjCClassMetaData
Needs ReviewPublic

Authored by sunbohong on Aug 27 2020, 10:52 PM.

Details

Reviewers
sepavloff
Summary

RedeclarePropertyAccessor (clang/lib/Sema/SemaObjCProperty.cpp shipped with https://reviews.llvm.org/rG2073dd2da702baca447efaf1879cb6151e8c6100) create a synthesized property accessor stub inside the @implementation, so we don't need produce metadata in RewriteModernObjC.cpp.

This commit will fix https://bugs.llvm.org/show_bug.cgi?id=47330

Diff Detail

Event Timeline

sunbohong created this revision.Aug 27 2020, 10:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2020, 10:52 PM
Herald added subscribers: cfe-commits, yaxunl. · View Herald Transcript
sunbohong requested review of this revision.Aug 27 2020, 10:52 PM
sunbohong retitled this revision from RedeclarePropertyAccessor (clang/lib/Sema/SemaObjCProperty.cpp shipped with https://reviews.llvm.org/rG2073dd2da702baca447efaf1879cb6151e8c6100) create a synthesized property accessor stub inside the @implementation, so we don't need produce... to Remove produce metadata in RewriteModernObjC::RewriteObjCClassMetaData.Aug 27 2020, 10:55 PM
sunbohong edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B69887: Diff 288532.Aug 28 2020, 12:04 AM
sunbohong added a reviewer: sepavloff.Aug 28 2020, 5:49 AM
sunbohong edited the summary of this revision. (Show Details)Aug 31 2020, 6:08 AM

Revision Contents

PathSize
clang/
lib/
Frontend/
Rewrite/
21 lines

Diff 288532

clang/lib/Frontend/Rewrite/RewriteModernObjC.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 7,018 Lines • ▼ Show 20 Linesvoid RewriteModernObjC::RewriteObjCClassMetaData(ObjCImplementationDecl *IDecl,
} }
Write__ivar_list_t_initializer(*this, Context, Result, IVars, Write__ivar_list_t_initializer(*this, Context, Result, IVars,
"_OBJC_$_INSTANCE_VARIABLES_", "_OBJC_$_INSTANCE_VARIABLES_",
CDecl); CDecl);
// Build _objc_method_list for class's instance methods if needed // Build _objc_method_list for class's instance methods if needed
SmallVector<ObjCMethodDecl *, 32> InstanceMethods(IDecl->instance_methods()); SmallVector<ObjCMethodDecl *, 32> InstanceMethods(IDecl->instance_methods());
// If any of our property implementations have associated getters or
// setters, produce metadata for them as well.
for (const auto *Prop : IDecl->property_impls()) {
if (Prop->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic)
continue;
if (!Prop->getPropertyIvarDecl())
continue;
ObjCPropertyDecl *PD = Prop->getPropertyDecl();
if (!PD)
continue;
if (ObjCMethodDecl *Getter = Prop->getGetterMethodDecl())
if (mustSynthesizeSetterGetterMethod(IDecl, PD, true /*getter*/))
InstanceMethods.push_back(Getter);
if (PD->isReadOnly())
continue;
if (ObjCMethodDecl *Setter = Prop->getSetterMethodDecl())
if (mustSynthesizeSetterGetterMethod(IDecl, PD, false /*setter*/))
InstanceMethods.push_back(Setter);
}
Write_method_list_t_initializer(*this, Context, Result, InstanceMethods, Write_method_list_t_initializer(*this, Context, Result, InstanceMethods,
"_OBJC_$_INSTANCE_METHODS_", "_OBJC_$_INSTANCE_METHODS_",
IDecl->getNameAsString(), true); IDecl->getNameAsString(), true);
SmallVector<ObjCMethodDecl *, 32> ClassMethods(IDecl->class_methods()); SmallVector<ObjCMethodDecl *, 32> ClassMethods(IDecl->class_methods());
Write_method_list_t_initializer(*this, Context, Result, ClassMethods, Write_method_list_t_initializer(*this, Context, Result, ClassMethods,
"_OBJC_$_CLASS_METHODS_", "_OBJC_$_CLASS_METHODS_",
▲ Show 20 Lines • Show All 516 Lines • Show Last 20 Lines