This is an archive of the discontinued LLVM Phabricator instance.

Differential D86722

[lldb] Make lldb-argdumper a dependency of liblldb
ClosedPublic

Authored by JDevlieghere on Aug 27 2020, 8:49 AM.

Details

Reviewers
kastiglione
davide
Commits
rGa7e4a1773535: [lldb] Make lldb-argdumper a dependency of liblldb
Summary

Always make lldb-argdumper a dependency of liblldb. Currently it is only a dependency of the python swig target because of the relative symlink in the python resource directory. That means that the dependency won't be there when LLDB_ENABLE_PYTHON is disabled.

Diff Detail

Event Timeline

JDevlieghere created this revision.Aug 27 2020, 8:49 AM
Herald added a subscriber: mgorny. · View Herald TranscriptAug 27 2020, 8:49 AM
JDevlieghere requested review of this revision.Aug 27 2020, 8:49 AM
kastiglione accepted this revision.Aug 27 2020, 9:15 AM
This revision is now accepted and ready to land.Aug 27 2020, 9:15 AM
davide accepted this revision.Aug 27 2020, 9:21 AM
Closed by commit rGa7e4a1773535: [lldb] Make lldb-argdumper a dependency of liblldb (authored by JDevlieghere). · Explain WhyAug 27 2020, 9:31 AM
This revision was automatically updated to reflect the committed changes.
JDevlieghere added a commit: rGa7e4a1773535: [lldb] Make lldb-argdumper a dependency of liblldb.
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2020, 9:31 AM

Revision Contents

PathSize
lldb/
tools/
argdumper/
2 lines

Diff 288368

lldb/tools/argdumper/CMakeLists.txt

add_lldb_tool(lldb-argdumper ADD_TO_FRAMEWORK add_lldb_tool(lldb-argdumper ADD_TO_FRAMEWORK
argdumper.cpp argdumper.cpp
LINK_COMPONENTS LINK_COMPONENTS
Support Support
) )
add_dependencies(liblldb lldb-argdumper)