This is an archive of the discontinued LLVM Phabricator instance.

Differential D86441

[SyntaxTree] Split ExplicitTemplateInstantiation test
ClosedPublic

Authored by eduucaldas on Aug 24 2020, 3:26 AM.

Details

Reviewers
gribozavr2
Commits
rGa722d6a197c7: [SyntaxTree] Split ExplicitTemplateInstantiation test

Diff Detail

Event Timeline

eduucaldas created this revision.Aug 24 2020, 3:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2020, 3:26 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
eduucaldas requested review of this revision.Aug 24 2020, 3:26 AM
eduucaldas added a reviewer: gribozavr2.Aug 24 2020, 3:27 AM
gribozavr2 accepted this revision.Aug 24 2020, 3:40 AM
gribozavr2 added inline comments.
clang/unittests/Tooling/Syntax/BuildTreeTest.cpp
3054
3076–3083
3099
3129
This revision is now accepted and ready to land.Aug 24 2020, 3:40 AM
Harbormaster completed remote builds in B69292: Diff 287330.Aug 24 2020, 4:00 AM
eduucaldas updated this revision to Diff 287378.Aug 24 2020, 7:01 AM
eduucaldas marked 4 inline comments as done.

Template -> ClassTemplate

This revision was landed with ongoing or failed builds.Aug 24 2020, 7:32 AM
Closed by commit rGa722d6a197c7: [SyntaxTree] Split ExplicitTemplateInstantiation test (authored by eduucaldas). · Explain Why
This revision was automatically updated to reflect the committed changes.
eduucaldas added a commit: rGa722d6a197c7: [SyntaxTree] Split ExplicitTemplateInstantiation test.
Harbormaster completed remote builds in B69315: Diff 287378.Aug 24 2020, 7:45 AM

Revision Contents

PathSize
clang/
unittests/
Tooling/
Syntax/
163 lines

Diff 287388

clang/unittests/Tooling/Syntax/BuildTreeTest.cpp

Show First 20 Lines • Show All 3,045 Lines • ▼ Show 20 Lines `-SimpleDeclaration
| | `-:: | | `-::
| |-bar | |-bar
| `-; | `-;
|-} |-}
`-; `-;
)txt")); )txt"));
} }
TEST_P(SyntaxTreeTest, ExplicitTemplateInstantations) { TEST_P(SyntaxTreeTest, ExplicitClassTemplateInstantation_Definition) {
gribozavr2Unsubmitted
Done
ReplyInline Actions
)txt"));
}
- TEST_P(SyntaxTreeTest, ExplicitTemplateInstantation_Definition) {
+ TEST_P(SyntaxTreeTest, ExplicitClassTemplateInstantation_Definition) {
if (!GetParam().isCXX()) {
gribozavr2:
if (!GetParam().isCXX()) { if (!GetParam().isCXX()) {
return; return;
} }
EXPECT_TRUE(treeDumpEqual( EXPECT_TRUE(treeDumpEqualOnAnnotations(
R"cpp( R"cpp(
template <class T> struct X {}; template <class T> struct X {};
template <class T> struct X<T*> {}; [[template struct X<double>;]]
template <> struct X<int> {}; )cpp",
{R"txt(
ExplicitTemplateInstantiation
|-template
`-SimpleDeclaration
|-struct
|-X
|-<
|-double
|->
`-;
)txt"}));
}
template struct X<double>; TEST_P(SyntaxTreeTest, ExplicitClassTemplateInstantation_Declaration) {
extern template struct X<float>; if (!GetParam().isCXX()) {
return;
}
EXPECT_TRUE(treeDumpEqualOnAnnotations(
R"cpp(
template <class T> struct X {};
[[extern template struct X<float>;]]
gribozavr2Unsubmitted
Done
ReplyInline Actions
)txt"}));
}
- TEST_P(SyntaxTreeTest, ExplicitTemplateInstantation_Declaration) {
+ TEST_P(SyntaxTreeTest, ExplicitClassTemplateInstantation_Declaration) {
if (!GetParam().isCXX()) {
gribozavr2:
)cpp", )cpp",
R"txt( {R"txt(
*: TranslationUnit ExplicitTemplateInstantiation
|-TemplateDeclaration
| |-template
| |-<
| |-UnknownDeclaration
| | |-class
| | `-T
| |->
| `-SimpleDeclaration
| |-struct
| |-X
| |-{
| |-}
| `-;
|-TemplateDeclaration
| |-template
| |-<
| |-UnknownDeclaration
| | |-class
| | `-T
| |->
| `-SimpleDeclaration
| |-struct
| |-X
| |-<
| |-T
| |-*
| |->
| |-{
| |-}
| `-;
|-TemplateDeclaration
| |-template
| |-<
| |->
| `-SimpleDeclaration
| |-struct
| |-X
| |-<
| |-int
| |->
| |-{
| |-}
| `-;
|-ExplicitTemplateInstantiation
| |-template
| `-SimpleDeclaration
| |-struct
| |-X
| |-<
| |-double
| |->
| `-;
`-ExplicitTemplateInstantiation
|-extern |-extern
|-template |-template
`-SimpleDeclaration `-SimpleDeclaration
|-struct |-struct
|-X |-X
|-< |-<
|-float |-float
|-> |->
`-; `-;
)txt")); )txt"}));
}
TEST_P(SyntaxTreeTest, ClassTemplateSpecialization_Partial) {
gribozavr2Unsubmitted
Done
ReplyInline Actions
)txt"}));
}
- TEST_P(SyntaxTreeTest, TemplateSpecialization_Partial) {
+ TEST_P(SyntaxTreeTest, ClassTemplateSpecialization_Partial) {
if (!GetParam().isCXX()) {
gribozavr2:
if (!GetParam().isCXX()) {
return;
}
EXPECT_TRUE(treeDumpEqualOnAnnotations(
R"cpp(
template <class T> struct X {};
[[template <class T> struct X<T*> {};]]
)cpp",
{R"txt(
TemplateDeclaration
|-template
|-<
|-UnknownDeclaration
| |-class
| `-T
|->
`-SimpleDeclaration
|-struct
|-X
|-<
|-T
|-*
|->
|-{
|-}
`-;
)txt"}));
}
TEST_P(SyntaxTreeTest, ClassTemplateSpecialization_Full) {
gribozavr2Unsubmitted
Done
ReplyInline Actions
)txt"}));
}
- TEST_P(SyntaxTreeTest, TemplateSpecialization_Full) {
+ TEST_P(SyntaxTreeTest, ClassTemplateSpecialization_Full) {
if (!GetParam().isCXX()) {
gribozavr2:
if (!GetParam().isCXX()) {
return;
}
EXPECT_TRUE(treeDumpEqualOnAnnotations(
R"cpp(
template <class T> struct X {};
[[template <> struct X<int> {};]]
)cpp",
{R"txt(
TemplateDeclaration
|-template
|-<
|->
`-SimpleDeclaration
|-struct
|-X
|-<
|-int
|->
|-{
|-}
`-;
)txt"}));
} }
TEST_P(SyntaxTreeTest, UsingType) { TEST_P(SyntaxTreeTest, UsingType) {
if (!GetParam().isCXX()) { if (!GetParam().isCXX()) {
return; return;
} }
EXPECT_TRUE(treeDumpEqual( EXPECT_TRUE(treeDumpEqual(
R"cpp( R"cpp(
▲ Show 20 Lines • Show All 1,067 Lines • Show Last 20 Lines