This is an archive of the discontinued LLVM Phabricator instance.

[SyntaxTree] Split tests related to Namespace
ClosedPublic

Authored by eduucaldas on Aug 18 2020, 7:03 AM.

Diff Detail

Event Timeline

eduucaldas created this revision.Aug 18 2020, 7:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2020, 7:03 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
eduucaldas requested review of this revision.Aug 18 2020, 7:03 AM
gribozavr2 accepted this revision.Aug 18 2020, 7:35 AM
gribozavr2 added inline comments.
clang/unittests/Tooling/Syntax/BuildTreeTest.cpp
2563

I think grouping this test under Namespace_ is not the best choice, because what's being tested here is the using, not the namespace.

2583

Ditto.

This revision is now accepted and ready to land.Aug 18 2020, 7:35 AM
eduucaldas marked 2 inline comments as done.

answer comments

This revision was landed with ongoing or failed builds.Aug 20 2020, 8:20 AM
This revision was automatically updated to reflect the committed changes.