Page MenuHomePhabricator

[lldb] Assert when TypeSystemClang::CreateFunctionDeclaration is called on a record
AcceptedPublic

Authored by teemperor on Aug 17 2020, 3:44 AM.

Details

Reviewers
labath
Summary

As discussed in D85993, using CreateFunctionDeclaration to add a member function to a record will probably
cause Clang to run into several assertions and is most likely not what one wants to do. All functions in a
record are CXXMethodDecls and never plain FunctionDecls. Not sure if there is an obscure Clang extension
that would support free functions inside a record, but I'm sure we don't have this use case when building an AST in LLDB.

Diff Detail

Event Timeline

teemperor requested review of this revision.Aug 17 2020, 3:44 AM
teemperor created this revision.
labath accepted this revision.Aug 18 2020, 8:51 AM

Sounds like a good idea, after the pdb plugin is fixed...

This revision is now accepted and ready to land.Aug 18 2020, 8:51 AM