This is an archive of the discontinued LLVM Phabricator instance.

Differential D85939

[NFC] Remove unused variables.
ClosedPublic

Authored by ckennelly on Aug 13 2020, 2:52 PM.

Details

Reviewers
rupprecht
Commits
rG097c8fb2cbc1: [NFC] Remove unused variables.
Summary

These were no longer needed following
96855125e77044b1a5d3c7f0ae90ea3a5cb035c0.

Diff Detail

Event Timeline

ckennelly created this revision.Aug 13 2020, 2:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2020, 2:52 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
ckennelly requested review of this revision.Aug 13 2020, 2:52 PM
rupprecht accepted this revision.Aug 13 2020, 2:55 PM
rupprecht added a subscriber: rupprecht.

This is the largest fix I've seen for unused variable warnings, but nonetheless looks correct.

This revision is now accepted and ready to land.Aug 13 2020, 2:55 PM
This revision was landed with ongoing or failed builds.Aug 13 2020, 2:57 PM
Closed by commit rG097c8fb2cbc1: [NFC] Remove unused variables. (authored by ckennelly). · Explain Why
This revision was automatically updated to reflect the committed changes.
ckennelly added a commit: rG097c8fb2cbc1: [NFC] Remove unused variables..
Harbormaster completed remote builds in B68338: Diff 285502.Aug 13 2020, 5:03 PM

Revision Contents

PathSize
compiler-rt/
lib/
tsan/
rtl/
35 lines

Diff 285503

compiler-rt/lib/tsan/rtl/tsan_platform_posix.cpp

Show First 20 Lines • Show All 50 Lines • ▼ Show 20 Lines if (!MmapFixedSuperNoReserve(ShadowBeg(), ShadowEnd() - ShadowBeg(),
Printf("FATAL: ThreadSanitizer can not mmap the shadow memory\n"); Printf("FATAL: ThreadSanitizer can not mmap the shadow memory\n");
Printf("FATAL: Make sure to compile with -fPIE and to link with -pie.\n"); Printf("FATAL: Make sure to compile with -fPIE and to link with -pie.\n");
Die(); Die();
} }
// This memory range is used for thread stacks and large user mmaps. // This memory range is used for thread stacks and large user mmaps.
// Frequently a thread uses only a small part of stack and similarly // Frequently a thread uses only a small part of stack and similarly
// a program uses a small part of large mmap. On some programs // a program uses a small part of large mmap. On some programs
// we see 20% memory usage reduction without huge pages for this range. // we see 20% memory usage reduction without huge pages for this range.
// FIXME: don't use constants here.
#if defined(__x86_64__)
const uptr kMadviseRangeBeg = 0x7f0000000000ull;
const uptr kMadviseRangeSize = 0x010000000000ull;
#elif defined(__mips64)
const uptr kMadviseRangeBeg = 0xff00000000ull;
const uptr kMadviseRangeSize = 0x0100000000ull;
#elif defined(__aarch64__) && defined(__APPLE__)
uptr kMadviseRangeBeg = LoAppMemBeg();
uptr kMadviseRangeSize = LoAppMemEnd() - LoAppMemBeg();
#elif defined(__aarch64__)
uptr kMadviseRangeBeg = 0;
uptr kMadviseRangeSize = 0;
if (vmaSize == 39) {
kMadviseRangeBeg = 0x7d00000000ull;
kMadviseRangeSize = 0x0300000000ull;
} else if (vmaSize == 42) {
kMadviseRangeBeg = 0x3f000000000ull;
kMadviseRangeSize = 0x01000000000ull;
} else {
DCHECK(0);
}
#elif defined(__powerpc64__)
uptr kMadviseRangeBeg = 0;
uptr kMadviseRangeSize = 0;
if (vmaSize == 44) {
kMadviseRangeBeg = 0x0f60000000ull;
kMadviseRangeSize = 0x0010000000ull;
} else if (vmaSize == 46) {
kMadviseRangeBeg = 0x3f0000000000ull;
kMadviseRangeSize = 0x010000000000ull;
} else {
DCHECK(0);
}
#endif
DontDumpShadow(ShadowBeg(), ShadowEnd() - ShadowBeg()); DontDumpShadow(ShadowBeg(), ShadowEnd() - ShadowBeg());
DPrintf("memory shadow: %zx-%zx (%zuGB)\n", DPrintf("memory shadow: %zx-%zx (%zuGB)\n",
ShadowBeg(), ShadowEnd(), ShadowBeg(), ShadowEnd(),
(ShadowEnd() - ShadowBeg()) >> 30); (ShadowEnd() - ShadowBeg()) >> 30);
// Map meta shadow. // Map meta shadow.
const uptr meta = MetaShadowBeg(); const uptr meta = MetaShadowBeg();
const uptr meta_size = MetaShadowEnd() - meta; const uptr meta_size = MetaShadowEnd() - meta;
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines