This is an archive of the discontinued LLVM Phabricator instance.

Differential D85888

Fix update_llc_test_checks function regex for RV64
ClosedPublic

Authored by arichardson on Aug 13 2020, 3:04 AM.

Details

Reviewers
MaskRay
Commits
rG3221c248d940: Fix update_llc_test_checks function regex for RV64
Summary

Some functions also include a .Lfunc$local: label

Diff Detail

Event Timeline

arichardson created this revision.Aug 13 2020, 3:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2020, 3:04 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
arichardson requested review of this revision.Aug 13 2020, 3:04 AM
Harbormaster completed remote builds in B68235: Diff 285300.Aug 13 2020, 3:40 AM
MaskRay accepted this revision.Aug 13 2020, 10:21 AM

Suggest mentioning -fno-semantic-interposition

.L<func>$local: due to -fno-semantic-interposition

This revision is now accepted and ready to land.Aug 13 2020, 10:21 AM
Closed by commit rG3221c248d940: Fix update_llc_test_checks function regex for RV64 (authored by arichardson). · Explain WhyAug 25 2020, 4:22 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG3221c248d940: Fix update_llc_test_checks function regex for RV64.

Revision Contents

PathSize
llvm/
utils/
UpdateTestChecks/
4 lines

Diff 287622

llvm/utils/UpdateTestChecks/asm.py

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 LinesASM_FUNCTION_PPC_RE = re.compile(
r'(?:\.Lfunc_[gl]ep[0-9]+:\n(?:[ \t]+.*?\n)*)*' r'(?:\.Lfunc_[gl]ep[0-9]+:\n(?:[ \t]+.*?\n)*)*'
r'(?P<body>.*?)\n' r'(?P<body>.*?)\n'
# This list is incomplete # This list is incomplete
r'(?:^[ \t]*(?:\.long[ \t]+[^\n]+|\.quad[ \t]+[^\n]+)\n)*' r'(?:^[ \t]*(?:\.long[ \t]+[^\n]+|\.quad[ \t]+[^\n]+)\n)*'
r'.Lfunc_end[0-9]+:\n', r'.Lfunc_end[0-9]+:\n',
flags=(re.M | re.S)) flags=(re.M | re.S))
ASM_FUNCTION_RISCV_RE = re.compile( ASM_FUNCTION_RISCV_RE = re.compile(
r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@(?P=func)\n(?:\s*\.?Lfunc_begin[^:\n]*:\n)?[^:]*?' r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@(?P=func)\n'
r'(?:\s*\.?L(?P=func)\$local:\n)?' # optional .L<func>$local: due to -fno-semantic-interposition
r'(?:\s*\.?Lfunc_begin[^:\n]*:\n)?[^:]*?'
r'(?P<body>^##?[ \t]+[^:]+:.*?)\s*' r'(?P<body>^##?[ \t]+[^:]+:.*?)\s*'
r'.Lfunc_end[0-9]+:\n', r'.Lfunc_end[0-9]+:\n',
flags=(re.M | re.S)) flags=(re.M | re.S))
ASM_FUNCTION_LANAI_RE = re.compile( ASM_FUNCTION_LANAI_RE = re.compile(
r'^_?(?P<func>[^:]+):[ \t]*!+[ \t]*@(?P=func)\n' r'^_?(?P<func>[^:]+):[ \t]*!+[ \t]*@(?P=func)\n'
r'(?:[ \t]+.cfi_startproc\n)?' # drop optional cfi noise r'(?:[ \t]+.cfi_startproc\n)?' # drop optional cfi noise
r'(?P<body>.*?)\s*' r'(?P<body>.*?)\s*'
▲ Show 20 Lines • Show All 286 Lines • Show Last 20 Lines