This is an archive of the discontinued LLVM Phabricator instance.

Differential D85843

Add "status" to the list of absl libraries.
ClosedPublic

Authored by oontvoo on Aug 12 2020, 9:25 AM.

Details

Reviewers
sbenza
Commits
rG114c9fa0e46f: Add "status" to the list of absl libraries.
Summary

The Abseil-NoInternalDependenciesCheck currently mistakenly triggers on any usage of internal helpers even if it is within absl/status.

Diff Detail

Event Timeline

oontvoo created this revision.Aug 12 2020, 9:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2020, 9:25 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
oontvoo requested review of this revision.Aug 12 2020, 9:25 AM
Harbormaster completed remote builds in B68126: Diff 285112.Aug 12 2020, 10:09 AM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 13 2020, 1:08 PM
Closed by commit rG114c9fa0e46f: Add "status" to the list of absl libraries. (authored by oontvoo). · Explain Why
This revision was automatically updated to reflect the committed changes.
oontvoo added a commit: rG114c9fa0e46f: Add "status" to the list of absl libraries..
oontvoo added a comment.Aug 13 2020, 1:09 PM

(With LGTM from sbenza)

Revision Contents

PathSize
clang-tools-extra/
clang-tidy/
abseil/
4 lines

Diff 285112

clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 LinesAST_POLYMORPHIC_MATCHER(
static constexpr llvm::StringLiteral AbslPrefix("absl/"); static constexpr llvm::StringLiteral AbslPrefix("absl/");
size_t PrefixPosition = Path.find(AbslPrefix); size_t PrefixPosition = Path.find(AbslPrefix);
if (PrefixPosition == StringRef::npos) if (PrefixPosition == StringRef::npos)
return false; return false;
Path = Path.drop_front(PrefixPosition + AbslPrefix.size()); Path = Path.drop_front(PrefixPosition + AbslPrefix.size());
static const char *AbseilLibraries[] = { static const char *AbseilLibraries[] = {
"algorithm", "base", "container", "debugging", "flags", "algorithm", "base", "container", "debugging", "flags",
"hash", "iterator", "memory", "meta", "numeric", "hash", "iterator", "memory", "meta", "numeric",
"random", "strings", "synchronization", "time", "types", "random", "strings", "synchronization", "status", "time",
"utility"}; "types", "utility"};
return std::any_of( return std::any_of(
std::begin(AbseilLibraries), std::end(AbseilLibraries), std::begin(AbseilLibraries), std::end(AbseilLibraries),
[&](const char *Library) { return Path.startswith(Library); }); [&](const char *Library) { return Path.startswith(Library); });
} }
} // namespace ast_matchers } // namespace ast_matchers
} // namespace clang } // namespace clang