We do that because:
- Big tests generated big tree dumps that could hardly serve as documentation.
- In most cases the tests didn't share setup, thus there was not much addition in lines of code.
Paths
| Differential D85819
[SyntaxTree] Split tests ClosedPublic Authored by eduucaldas on Aug 12 2020, 1:57 AM.
Details
Summary We do that because:
Diff Detail
Event TimelineComment Actions Before we had an UnqualifiedId test that tested for everything in the grammar. Now we just split this test and test the alternatives separately.
Comment Actions Split tests for UserDefinedLiteral
Comment Actions Please also consider splitting the file into multiple.
This revision is now accepted and ready to land.Aug 12 2020, 3:47 PM
This revision was landed with ongoing or failed builds.Aug 13 2020, 1:18 AM Closed by commit rGd1211fd1ec03: [SyntaxTree] Split tests for expressions (authored by eduucaldas). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 285278 clang/unittests/Tooling/Syntax/TreeTest.cpp
|
It seems inappropriate to always repeat UnqualfiiedId, do you have any other suggestion?