This is an archive of the discontinued LLVM Phabricator instance.

Differential D85708

[lldb/CMake] Separate CMake code for Lua and Python (NFC)
ClosedPublic

Authored by JDevlieghere on Aug 10 2020, 11:15 PM.

Details

Reviewers
labath
Group Reviewers
Restricted Project
Commits
rGc135744b1df3: [lldb/CMake] Separate CMake code for Lua and Python (NFC)
Summary

Separate the CMake logic for Lua and Python to clearly distinguish between code specific to either scripting language and the code shared by both.

What this patch does is:

  • Move Python specific code into the bindings/python subdirectory.
  • Move the Lua specific code into the bindings/lua subdirectory.
  • Add the _python suffix to Python specific functions/targets.
  • Fix a dependency issue that would check the binding instead of whether the scripting language is enabled.

Diff Detail

Event Timeline

JDevlieghere created this revision.Aug 10 2020, 11:15 PM
Herald added a subscriber: mgorny. · View Herald TranscriptAug 10 2020, 11:15 PM
JDevlieghere requested review of this revision.Aug 10 2020, 11:15 PM
JDevlieghere edited the summary of this revision. (Show Details)Aug 10 2020, 11:20 PM
labath accepted this revision.Aug 11 2020, 5:09 AM
labath added a subscriber: labath.

sounds like a good idea

This revision is now accepted and ready to land.Aug 11 2020, 5:09 AM
Closed by commit rGc135744b1df3: [lldb/CMake] Separate CMake code for Lua and Python (NFC) (authored by JDevlieghere). · Explain WhyAug 11 2020, 9:04 AM
This revision was automatically updated to reflect the committed changes.
JDevlieghere added a commit: rGc135744b1df3: [lldb/CMake] Separate CMake code for Lua and Python (NFC).
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2020, 9:04 AM

Revision Contents

PathSize
lldb/
6 lines
bindings/
208 lines
lua/
17 lines
lua/
python/
189 lines
python/
docs/
6 lines
source/
API/
20 lines

Diff 284583

lldb/CMakeLists.txt

Show First 20 Lines • Show All 73 Lines • ▼ Show 20 Lines
# TableGen # TableGen
add_subdirectory(utils/TableGen) add_subdirectory(utils/TableGen)
add_subdirectory(source) add_subdirectory(source)
add_subdirectory(tools) add_subdirectory(tools)
add_subdirectory(docs) add_subdirectory(docs)
if (LLDB_ENABLE_PYTHON OR LLDB_ENABLE_LUA) if (LLDB_ENABLE_PYTHON)
if(LLDB_BUILD_FRAMEWORK) if(LLDB_BUILD_FRAMEWORK)
set(lldb_python_target_dir "${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.framework/Resources/Python/lldb") set(lldb_python_target_dir "${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.framework/Resources/Python/lldb")
else() else()
set(lldb_python_target_dir "${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/${LLDB_PYTHON_RELATIVE_PATH}/lldb") set(lldb_python_target_dir "${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/${LLDB_PYTHON_RELATIVE_PATH}/lldb")
endif() endif()
get_target_property(lldb_bindings_dir swig_wrapper BINARY_DIR) get_target_property(lldb_python_bindings_dir swig_wrapper_python BINARY_DIR)
finish_swig("finish_swig" "${lldb_bindings_dir}" "${lldb_python_target_dir}") finish_swig_python("finish_swig_python" "${lldb_python_bindings_dir}" "${lldb_python_target_dir}")
endif() endif()
option(LLDB_INCLUDE_TESTS "Generate build targets for the LLDB unit tests." ${LLVM_INCLUDE_TESTS}) option(LLDB_INCLUDE_TESTS "Generate build targets for the LLDB unit tests." ${LLVM_INCLUDE_TESTS})
if(LLDB_INCLUDE_TESTS) if(LLDB_INCLUDE_TESTS)
add_subdirectory(test) add_subdirectory(test)
add_subdirectory(unittests) add_subdirectory(unittests)
add_subdirectory(utils) add_subdirectory(utils)
endif() endif()
if(LLDB_BUILT_STANDALONE AND NOT LLVM_ENABLE_IDE) if(LLDB_BUILT_STANDALONE AND NOT LLVM_ENABLE_IDE)
llvm_distribution_add_targets() llvm_distribution_add_targets()
endif() endif()

lldb/bindings/CMakeLists.txt

Show All 27 Linesset(SWIG_COMMON_FLAGS
-I${CMAKE_CURRENT_SOURCE_DIR} -I${CMAKE_CURRENT_SOURCE_DIR}
-D__STDC_LIMIT_MACROS -D__STDC_LIMIT_MACROS
-D__STDC_CONSTANT_MACROS -D__STDC_CONSTANT_MACROS
${DARWIN_EXTRAS} ${DARWIN_EXTRAS}
-outdir ${CMAKE_CURRENT_BINARY_DIR} -outdir ${CMAKE_CURRENT_BINARY_DIR}
) )
if (LLDB_ENABLE_PYTHON) if (LLDB_ENABLE_PYTHON)
add_custom_command( add_subdirectory(python)
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapPython.cpp
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/lldb.py
DEPENDS ${SWIG_SOURCES}
DEPENDS ${SWIG_INTERFACES}
DEPENDS ${SWIG_HEADERS}
COMMAND ${SWIG_EXECUTABLE}
${SWIG_COMMON_FLAGS}
-c++
-shadow
-python
-threads
-o ${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapPython.cpp
${LLDB_SOURCE_DIR}/bindings/python.swig
VERBATIM
COMMENT "Building LLDB Python wrapper")
add_custom_target(swig_wrapper ALL DEPENDS
${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapPython.cpp
${CMAKE_CURRENT_BINARY_DIR}/lldb.py
)
endif() endif()
if (LLDB_ENABLE_LUA) if (LLDB_ENABLE_LUA)
add_custom_command( add_subdirectory(lua)
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapLua.cpp
DEPENDS ${SWIG_SOURCES}
DEPENDS ${SWIG_INTERFACES}
DEPENDS ${SWIG_HEADERS}
COMMAND ${SWIG_EXECUTABLE}
${SWIG_COMMON_FLAGS}
-lua
-w503
-o ${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapLua.cpp
${LLDB_SOURCE_DIR}/bindings/lua.swig
VERBATIM
COMMENT "Building LLDB Lua wrapper")
add_custom_target(swig_wrapper_lua ALL DEPENDS
${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapLua.cpp
)
endif()
function(create_python_package swig_target working_dir pkg_dir)
cmake_parse_arguments(ARG "NOINIT" "" "FILES" ${ARGN})
if(ARG_FILES)
set(copy_cmd COMMAND ${CMAKE_COMMAND} -E copy ${ARG_FILES} ${pkg_dir})
endif()
if(NOT ARG_NOINIT)
set(init_cmd COMMAND ${PYTHON_EXECUTABLE}
"${LLDB_SOURCE_DIR}/bindings/python/createPythonInit.py"
"${pkg_dir}" ${ARG_FILES})
endif()
add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM
COMMAND ${CMAKE_COMMAND} -E make_directory ${pkg_dir}
${copy_cmd}
${init_cmd}
WORKING_DIRECTORY ${working_dir})
endfunction()
function(create_relative_symlink swig_target dest_file output_dir output_name)
get_filename_component(dest_file ${dest_file} ABSOLUTE)
get_filename_component(output_dir ${output_dir} ABSOLUTE)
file(RELATIVE_PATH rel_dest_file ${output_dir} ${dest_file})
if(CMAKE_HOST_UNIX)
set(LLVM_LINK_OR_COPY create_symlink)
else()
set(LLVM_LINK_OR_COPY copy)
endif()
add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM
COMMAND ${CMAKE_COMMAND} -E ${LLVM_LINK_OR_COPY} ${rel_dest_file} ${output_name}
WORKING_DIRECTORY ${output_dir})
endfunction()
function(finish_swig swig_target lldb_bindings_dir lldb_python_target_dir)
# Add a Post-Build Event to copy over Python files and create the symlink to
# liblldb.so for the Python API(hardlink on Windows).
add_custom_target(${swig_target} ALL VERBATIM
COMMAND ${CMAKE_COMMAND} -E make_directory ${lldb_python_target_dir}
DEPENDS ${lldb_bindings_dir}/lldb.py
COMMENT "Python script sym-linking LLDB Python API")
if(NOT LLDB_USE_SYSTEM_SIX)
add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM
COMMAND ${CMAKE_COMMAND} -E copy
"${LLDB_SOURCE_DIR}/third_party/Python/module/six/six.py"
"${lldb_python_target_dir}/../six.py")
endif()
add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM
COMMAND ${CMAKE_COMMAND} -E copy
"${lldb_bindings_dir}/lldb.py"
"${lldb_python_target_dir}/__init__.py")
add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM
COMMAND ${CMAKE_COMMAND} -E copy
"${LLDB_SOURCE_DIR}/source/Interpreter/embedded_interpreter.py"
"${lldb_python_target_dir}")
# Distribute the examples as python packages.
create_python_package(
${swig_target}
${lldb_python_target_dir}
"formatters/cpp"
FILES "${LLDB_SOURCE_DIR}/examples/synthetic/gnu_libstdcpp.py"
"${LLDB_SOURCE_DIR}/examples/synthetic/libcxx.py")
create_python_package(
${swig_target}
${lldb_python_target_dir}
"formatters"
FILES "${LLDB_SOURCE_DIR}/examples/summaries/cocoa/cache.py"
"${LLDB_SOURCE_DIR}/examples/summaries/synth.py"
"${LLDB_SOURCE_DIR}/examples/summaries/cocoa/metrics.py"
"${LLDB_SOURCE_DIR}/examples/summaries/cocoa/attrib_fromdict.py"
"${LLDB_SOURCE_DIR}/examples/summaries/cocoa/Logger.py")
create_python_package(
${swig_target}
${lldb_python_target_dir}
"utils"
FILES "${LLDB_SOURCE_DIR}/examples/python/in_call_stack.py"
"${LLDB_SOURCE_DIR}/examples/python/symbolication.py")
if(APPLE)
create_python_package(
${swig_target}
${lldb_python_target_dir} "macosx"
FILES "${LLDB_SOURCE_DIR}/examples/python/crashlog.py"
"${LLDB_SOURCE_DIR}/examples/darwin/heap_find/heap.py")
create_python_package(
${swig_target}
${lldb_python_target_dir} "macosx/heap"
FILES "${LLDB_SOURCE_DIR}/examples/darwin/heap_find/heap/heap_find.cpp"
"${LLDB_SOURCE_DIR}/examples/darwin/heap_find/heap/Makefile"
NOINIT)
create_python_package(
${swig_target}
${lldb_python_target_dir} "diagnose"
FILES "${LLDB_SOURCE_DIR}/examples/python/diagnose_unwind.py"
"${LLDB_SOURCE_DIR}/examples/python/diagnose_nsstring.py")
endif()
if(LLDB_BUILD_FRAMEWORK)
set(LIBLLDB_SYMLINK_DEST "${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.framework/LLDB")
else()
set(LIBLLDB_SYMLINK_DEST "${LLVM_SHLIB_OUTPUT_INTDIR}/liblldb${CMAKE_SHARED_LIBRARY_SUFFIX}")
endif()
if(WIN32)
if(CMAKE_BUILD_TYPE STREQUAL Debug)
set(LIBLLDB_SYMLINK_OUTPUT_FILE "_lldb_d.pyd")
else()
set(LIBLLDB_SYMLINK_OUTPUT_FILE "_lldb.pyd")
endif()
else()
set(LIBLLDB_SYMLINK_OUTPUT_FILE "_lldb.so")
endif()
create_relative_symlink(${swig_target} ${LIBLLDB_SYMLINK_DEST}
${lldb_python_target_dir} ${LIBLLDB_SYMLINK_OUTPUT_FILE})
if(NOT LLDB_BUILD_FRAMEWORK)
set(LLDB_ARGDUMPER_FILENAME "lldb-argdumper${CMAKE_EXECUTABLE_SUFFIX}")
create_relative_symlink(${swig_target} "${LLVM_RUNTIME_OUTPUT_INTDIR}/${LLDB_ARGDUMPER_FILENAME}"
${lldb_python_target_dir} ${LLDB_ARGDUMPER_FILENAME})
endif()
add_dependencies(${swig_target} swig_wrapper liblldb lldb-argdumper)
set_target_properties(${swig_target} swig_wrapper PROPERTIES FOLDER "lldb misc")
# Ensure we do the python post-build step when building lldb.
add_dependencies(lldb ${swig_target})
# Install the LLDB python module
if(LLDB_BUILD_FRAMEWORK)
set(LLDB_PYTHON_INSTALL_PATH ${LLDB_FRAMEWORK_INSTALL_DIR}/LLDB.framework/Resources/Python)
else()
set(LLDB_PYTHON_INSTALL_PATH ${LLDB_PYTHON_RELATIVE_PATH})
endif()
if (NOT CMAKE_CFG_INTDIR STREQUAL ".")
string(REPLACE ${CMAKE_CFG_INTDIR} "\$\{CMAKE_INSTALL_CONFIG_NAME\}" LLDB_PYTHON_INSTALL_PATH ${LLDB_PYTHON_INSTALL_PATH})
string(REPLACE ${CMAKE_CFG_INTDIR} "\$\{CMAKE_INSTALL_CONFIG_NAME\}" lldb_python_target_dir ${lldb_python_target_dir})
endif()
set(swig_scripts_target "${swig_target}_scripts")
set(swig_scripts_install_target "${swig_target}_scripts_install")
add_custom_target(${swig_scripts_target})
add_dependencies(${swig_scripts_target} ${swig_target})
install(DIRECTORY ${lldb_python_target_dir}/../
DESTINATION ${LLDB_PYTHON_INSTALL_PATH}
COMPONENT ${swig_scripts_target})
if (NOT LLVM_ENABLE_IDE)
add_llvm_install_targets(${swig_scripts_install_target}
COMPONENT ${swig_scripts_target}
DEPENDS ${swig_scripts_target})
endif()
# Add a Post-Build Event to copy the custom Python DLL to the lldb binaries dir so that Windows can find it when launching
# lldb.exe or any other executables that were linked with liblldb.
if (WIN32 AND NOT "${PYTHON_DLL}" STREQUAL "")
# When using the Visual Studio CMake generator the lldb binaries end up in Release/bin, Debug/bin etc.
file(TO_NATIVE_PATH "${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin" LLDB_BIN_DIR)
file(TO_NATIVE_PATH "${PYTHON_DLL}" PYTHON_DLL_NATIVE_PATH)
add_custom_command(
TARGET ${swig_target}
POST_BUILD
COMMAND ${CMAKE_COMMAND} -E copy ${PYTHON_DLL_NATIVE_PATH} ${LLDB_BIN_DIR} VERBATIM
COMMENT "Copying Python DLL to LLDB binaries directory.")
endif() endif()
endfunction()

lldb/bindings/lua.swig

  • This file was moved to lldb/bindings/lua/lua.swig.

lldb/bindings/lua/CMakeLists.txt

  • This file was added.
add_custom_command(
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapLua.cpp
DEPENDS ${SWIG_SOURCES}
DEPENDS ${SWIG_INTERFACES}
DEPENDS ${SWIG_HEADERS}
COMMAND ${SWIG_EXECUTABLE}
${SWIG_COMMON_FLAGS}
-lua
-w503
-o ${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapLua.cpp
${CMAKE_CURRENT_SOURCE_DIR}/lua.swig
VERBATIM
COMMENT "Building LLDB Lua wrapper")
add_custom_target(swig_wrapper_lua ALL DEPENDS
${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapLua.cpp
)

lldb/bindings/lua/lua.swig

  • This file was moved from lldb/bindings/lua.swig.
The contents of this file were not changed.

lldb/bindings/python.swig

  • This file was moved to lldb/bindings/python/python.swig.

lldb/bindings/python/CMakeLists.txt

  • This file was added.
add_custom_command(
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapPython.cpp
OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/lldb.py
DEPENDS ${SWIG_SOURCES}
DEPENDS ${SWIG_INTERFACES}
DEPENDS ${SWIG_HEADERS}
COMMAND ${SWIG_EXECUTABLE}
${SWIG_COMMON_FLAGS}
-c++
-shadow
-python
-threads
-o ${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapPython.cpp
${CMAKE_CURRENT_SOURCE_DIR}/python.swig
VERBATIM
COMMENT "Building LLDB Python wrapper")
add_custom_target(swig_wrapper_python ALL DEPENDS
${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapPython.cpp
${CMAKE_CURRENT_BINARY_DIR}/lldb.py
)
function(create_python_package swig_target working_dir pkg_dir)
cmake_parse_arguments(ARG "NOINIT" "" "FILES" ${ARGN})
if(ARG_FILES)
set(copy_cmd COMMAND ${CMAKE_COMMAND} -E copy ${ARG_FILES} ${pkg_dir})
endif()
if(NOT ARG_NOINIT)
set(init_cmd COMMAND ${PYTHON_EXECUTABLE}
"${LLDB_SOURCE_DIR}/bindings/python/createPythonInit.py"
"${pkg_dir}" ${ARG_FILES})
endif()
add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM
COMMAND ${CMAKE_COMMAND} -E make_directory ${pkg_dir}
${copy_cmd}
${init_cmd}
WORKING_DIRECTORY ${working_dir})
endfunction()
function(create_relative_symlink swig_target dest_file output_dir output_name)
get_filename_component(dest_file ${dest_file} ABSOLUTE)
get_filename_component(output_dir ${output_dir} ABSOLUTE)
file(RELATIVE_PATH rel_dest_file ${output_dir} ${dest_file})
if(CMAKE_HOST_UNIX)
set(LLVM_LINK_OR_COPY create_symlink)
else()
set(LLVM_LINK_OR_COPY copy)
endif()
add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM
COMMAND ${CMAKE_COMMAND} -E ${LLVM_LINK_OR_COPY} ${rel_dest_file} ${output_name}
WORKING_DIRECTORY ${output_dir})
endfunction()
function(finish_swig_python swig_target lldb_python_bindings_dir lldb_python_target_dir)
# Add a Post-Build Event to copy over Python files and create the symlink to
# liblldb.so for the Python API(hardlink on Windows).
add_custom_target(${swig_target} ALL VERBATIM
COMMAND ${CMAKE_COMMAND} -E make_directory ${lldb_python_target_dir}
DEPENDS ${lldb_python_bindings_dir}/lldb.py
COMMENT "Python script sym-linking LLDB Python API")
if(NOT LLDB_USE_SYSTEM_SIX)
add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM
COMMAND ${CMAKE_COMMAND} -E copy
"${LLDB_SOURCE_DIR}/third_party/Python/module/six/six.py"
"${lldb_python_target_dir}/../six.py")
endif()
add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM
COMMAND ${CMAKE_COMMAND} -E copy
"${lldb_python_bindings_dir}/lldb.py"
"${lldb_python_target_dir}/__init__.py")
add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM
COMMAND ${CMAKE_COMMAND} -E copy
"${LLDB_SOURCE_DIR}/source/Interpreter/embedded_interpreter.py"
"${lldb_python_target_dir}")
# Distribute the examples as python packages.
create_python_package(
${swig_target}
${lldb_python_target_dir}
"formatters/cpp"
FILES "${LLDB_SOURCE_DIR}/examples/synthetic/gnu_libstdcpp.py"
"${LLDB_SOURCE_DIR}/examples/synthetic/libcxx.py")
create_python_package(
${swig_target}
${lldb_python_target_dir}
"formatters"
FILES "${LLDB_SOURCE_DIR}/examples/summaries/cocoa/cache.py"
"${LLDB_SOURCE_DIR}/examples/summaries/synth.py"
"${LLDB_SOURCE_DIR}/examples/summaries/cocoa/metrics.py"
"${LLDB_SOURCE_DIR}/examples/summaries/cocoa/attrib_fromdict.py"
"${LLDB_SOURCE_DIR}/examples/summaries/cocoa/Logger.py")
create_python_package(
${swig_target}
${lldb_python_target_dir}
"utils"
FILES "${LLDB_SOURCE_DIR}/examples/python/in_call_stack.py"
"${LLDB_SOURCE_DIR}/examples/python/symbolication.py")
if(APPLE)
create_python_package(
${swig_target}
${lldb_python_target_dir} "macosx"
FILES "${LLDB_SOURCE_DIR}/examples/python/crashlog.py"
"${LLDB_SOURCE_DIR}/examples/darwin/heap_find/heap.py")
create_python_package(
${swig_target}
${lldb_python_target_dir} "macosx/heap"
FILES "${LLDB_SOURCE_DIR}/examples/darwin/heap_find/heap/heap_find.cpp"
"${LLDB_SOURCE_DIR}/examples/darwin/heap_find/heap/Makefile"
NOINIT)
create_python_package(
${swig_target}
${lldb_python_target_dir} "diagnose"
FILES "${LLDB_SOURCE_DIR}/examples/python/diagnose_unwind.py"
"${LLDB_SOURCE_DIR}/examples/python/diagnose_nsstring.py")
endif()
if(LLDB_BUILD_FRAMEWORK)
set(LIBLLDB_SYMLINK_DEST "${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.framework/LLDB")
else()
set(LIBLLDB_SYMLINK_DEST "${LLVM_SHLIB_OUTPUT_INTDIR}/liblldb${CMAKE_SHARED_LIBRARY_SUFFIX}")
endif()
if(WIN32)
if(CMAKE_BUILD_TYPE STREQUAL Debug)
set(LIBLLDB_SYMLINK_OUTPUT_FILE "_lldb_d.pyd")
else()
set(LIBLLDB_SYMLINK_OUTPUT_FILE "_lldb.pyd")
endif()
else()
set(LIBLLDB_SYMLINK_OUTPUT_FILE "_lldb.so")
endif()
create_relative_symlink(${swig_target} ${LIBLLDB_SYMLINK_DEST}
${lldb_python_target_dir} ${LIBLLDB_SYMLINK_OUTPUT_FILE})
if(NOT LLDB_BUILD_FRAMEWORK)
set(LLDB_ARGDUMPER_FILENAME "lldb-argdumper${CMAKE_EXECUTABLE_SUFFIX}")
create_relative_symlink(${swig_target} "${LLVM_RUNTIME_OUTPUT_INTDIR}/${LLDB_ARGDUMPER_FILENAME}"
${lldb_python_target_dir} ${LLDB_ARGDUMPER_FILENAME})
endif()
add_dependencies(${swig_target} swig_wrapper_python liblldb lldb-argdumper)
set_target_properties(${swig_target} swig_wrapper_python PROPERTIES FOLDER "lldb misc")
# Ensure we do the python post-build step when building lldb.
add_dependencies(lldb ${swig_target})
# Install the LLDB python module
if(LLDB_BUILD_FRAMEWORK)
set(LLDB_PYTHON_INSTALL_PATH ${LLDB_FRAMEWORK_INSTALL_DIR}/LLDB.framework/Resources/Python)
else()
set(LLDB_PYTHON_INSTALL_PATH ${LLDB_PYTHON_RELATIVE_PATH})
endif()
if (NOT CMAKE_CFG_INTDIR STREQUAL ".")
string(REPLACE ${CMAKE_CFG_INTDIR} "\$\{CMAKE_INSTALL_CONFIG_NAME\}" LLDB_PYTHON_INSTALL_PATH ${LLDB_PYTHON_INSTALL_PATH})
string(REPLACE ${CMAKE_CFG_INTDIR} "\$\{CMAKE_INSTALL_CONFIG_NAME\}" lldb_python_target_dir ${lldb_python_target_dir})
endif()
set(swig_scripts_target "${swig_target}_scripts")
set(swig_scripts_install_target "${swig_target}_scripts_install")
add_custom_target(${swig_scripts_target})
add_dependencies(${swig_scripts_target} ${swig_target})
install(DIRECTORY ${lldb_python_target_dir}/../
DESTINATION ${LLDB_PYTHON_INSTALL_PATH}
COMPONENT ${swig_scripts_target})
if (NOT LLVM_ENABLE_IDE)
add_llvm_install_targets(${swig_scripts_install_target}
COMPONENT ${swig_scripts_target}
DEPENDS ${swig_scripts_target})
endif()
# Add a Post-Build Event to copy the custom Python DLL to the lldb binaries dir so that Windows can find it when launching
# lldb.exe or any other executables that were linked with liblldb.
if (WIN32 AND NOT "${PYTHON_DLL}" STREQUAL "")
# When using the Visual Studio CMake generator the lldb binaries end up in Release/bin, Debug/bin etc.
file(TO_NATIVE_PATH "${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin" LLDB_BIN_DIR)
file(TO_NATIVE_PATH "${PYTHON_DLL}" PYTHON_DLL_NATIVE_PATH)
add_custom_command(
TARGET ${swig_target}
POST_BUILD
COMMAND ${CMAKE_COMMAND} -E copy ${PYTHON_DLL_NATIVE_PATH} ${LLDB_BIN_DIR} VERBATIM
COMMENT "Copying Python DLL to LLDB binaries directory.")
endif()
endfunction()

lldb/bindings/python/python.swig

  • This file was moved from lldb/bindings/python.swig.
The contents of this file were not changed.

lldb/docs/CMakeLists.txt

Show All 24 Lines if(DOT_EXECUTABLE)
set(EPYDOC_OPTIONS ${EPYDOC_OPTIONS} --graph all --dotpath ${DOT_EXECUTABLE}) set(EPYDOC_OPTIONS ${EPYDOC_OPTIONS} --graph all --dotpath ${DOT_EXECUTABLE})
message(STATUS "Found dot - ${DOT_EXECUTABLE}") message(STATUS "Found dot - ${DOT_EXECUTABLE}")
endif() endif()
# Pretend to make a python package so that we can generate the reference. # Pretend to make a python package so that we can generate the reference.
# Because we don't build liblldb, epydoc will complain that the import of # Because we don't build liblldb, epydoc will complain that the import of
# _lldb.so failed, but that doesn't prevent it from generating the docs. # _lldb.so failed, but that doesn't prevent it from generating the docs.
file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/lldb) file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/lldb)
get_target_property(lldb_bindings_dir swig_wrapper BINARY_DIR) get_target_property(lldb_bindings_dir swig_wrapper_python BINARY_DIR)
add_custom_target(lldb-python-doc-package add_custom_target(lldb-python-doc-package
COMMAND "${CMAKE_COMMAND}" -E copy "${lldb_bindings_dir}/lldb.py" "${CMAKE_CURRENT_BINARY_DIR}/lldb/__init__.py" COMMAND "${CMAKE_COMMAND}" -E copy "${lldb_bindings_dir}/lldb.py" "${CMAKE_CURRENT_BINARY_DIR}/lldb/__init__.py"
COMMENT "Copying lldb.py to pretend package.") COMMENT "Copying lldb.py to pretend package.")
add_dependencies(lldb-python-doc-package swig_wrapper) add_dependencies(lldb-python-doc-package swig_wrapper_python)
set(DOC_DIR "${CMAKE_CURRENT_SOURCE_DIR}/doc") set(DOC_DIR "${CMAKE_CURRENT_SOURCE_DIR}/doc")
file(MAKE_DIRECTORY "${DOC_DIR}") file(MAKE_DIRECTORY "${DOC_DIR}")
add_custom_target(lldb-python-doc add_custom_target(lldb-python-doc
${EPYDOC_EXECUTABLE} ${EPYDOC_EXECUTABLE}
--html --html
lldb lldb
-o ${CMAKE_CURRENT_BINARY_DIR}/python_reference -o ${CMAKE_CURRENT_BINARY_DIR}/python_reference
--name "LLDB python API" --name "LLDB python API"
--url "http://lldb.llvm.org" --url "http://lldb.llvm.org"
${EPYDOC_OPTIONS} ${EPYDOC_OPTIONS}
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
COMMENT "Generating LLDB Python API reference with epydoc" VERBATIM COMMENT "Generating LLDB Python API reference with epydoc" VERBATIM
) )
add_dependencies(lldb-python-doc swig_wrapper lldb-python-doc-package) add_dependencies(lldb-python-doc swig_wrapper_python lldb-python-doc-package)
else() else()
message(STATUS "Could NOT find epydoc") message(STATUS "Could NOT find epydoc")
endif() endif()
endif () endif ()
if (LLVM_ENABLE_SPHINX) if (LLVM_ENABLE_SPHINX)
include(AddSphinxTarget) include(AddSphinxTarget)
if (SPHINX_FOUND) if (SPHINX_FOUND)
Show All 14 Lines

lldb/source/API/CMakeLists.txt

if ( CMAKE_SYSTEM_NAME MATCHES "Windows" ) if ( CMAKE_SYSTEM_NAME MATCHES "Windows" )
add_definitions( -DEXPORT_LIBLLDB ) add_definitions( -DEXPORT_LIBLLDB )
endif() endif()
get_property(LLDB_ALL_PLUGINS GLOBAL PROPERTY LLDB_PLUGINS) get_property(LLDB_ALL_PLUGINS GLOBAL PROPERTY LLDB_PLUGINS)
if(LLDB_ENABLE_PYTHON)
get_target_property(lldb_bindings_dir swig_wrapper BINARY_DIR)
set(lldb_python_wrapper ${lldb_bindings_dir}/LLDBWrapPython.cpp)
endif()
if(LLDB_ENABLE_LUA)
get_target_property(lldb_bindings_dir swig_wrapper_lua BINARY_DIR)
set(lldb_lua_wrapper ${lldb_bindings_dir}/LLDBWrapLua.cpp)
endif()
if(LLDB_BUILD_FRAMEWORK) if(LLDB_BUILD_FRAMEWORK)
set(option_install_prefix INSTALL_PREFIX ${LLDB_FRAMEWORK_INSTALL_DIR}) set(option_install_prefix INSTALL_PREFIX ${LLDB_FRAMEWORK_INSTALL_DIR})
set(option_framework FRAMEWORK) set(option_framework FRAMEWORK)
endif() endif()
add_lldb_library(liblldb SHARED ${option_framework} add_lldb_library(liblldb SHARED ${option_framework}
SBAddress.cpp SBAddress.cpp
SBAttachInfo.cpp SBAttachInfo.cpp
▲ Show 20 Lines • Show All 97 Lines • ▼ Show 20 Lines
endif() endif()
if(PYTHON_RPATH) if(PYTHON_RPATH)
set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH "${PYTHON_RPATH}") set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH "${PYTHON_RPATH}")
set_property(TARGET liblldb APPEND PROPERTY BUILD_RPATH "${PYTHON_RPATH}") set_property(TARGET liblldb APPEND PROPERTY BUILD_RPATH "${PYTHON_RPATH}")
endif() endif()
if(lldb_python_wrapper) if(LLDB_ENABLE_PYTHON)
add_dependencies(liblldb swig_wrapper) add_dependencies(liblldb swig_wrapper_python)
get_target_property(lldb_bindings_dir swig_wrapper_python BINARY_DIR)
set(lldb_python_wrapper ${lldb_bindings_dir}/LLDBWrapPython.cpp)
if (MSVC) if (MSVC)
set_property(SOURCE ${lldb_python_wrapper} APPEND_STRING PROPERTY COMPILE_FLAGS " /W0") set_property(SOURCE ${lldb_python_wrapper} APPEND_STRING PROPERTY COMPILE_FLAGS " /W0")
else() else()
set_property(SOURCE ${lldb_python_wrapper} APPEND_STRING PROPERTY COMPILE_FLAGS " -w") set_property(SOURCE ${lldb_python_wrapper} APPEND_STRING PROPERTY COMPILE_FLAGS " -w")
endif() endif()
set_source_files_properties(${lldb_python_wrapper} PROPERTIES GENERATED ON) set_source_files_properties(${lldb_python_wrapper} PROPERTIES GENERATED ON)
if (CLANG_CL) if (CLANG_CL)
set_property(SOURCE ${lldb_python_wrapper} APPEND_STRING set_property(SOURCE ${lldb_python_wrapper} APPEND_STRING
PROPERTY COMPILE_FLAGS " -Wno-unused-function") PROPERTY COMPILE_FLAGS " -Wno-unused-function")
endif() endif()
if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND
NOT "${CMAKE_SYSTEM_NAME}" MATCHES "Darwin") NOT "${CMAKE_SYSTEM_NAME}" MATCHES "Darwin")
set_property(SOURCE ${lldb_python_wrapper} APPEND_STRING set_property(SOURCE ${lldb_python_wrapper} APPEND_STRING
PROPERTY COMPILE_FLAGS " -Wno-sequence-point -Wno-cast-qual") PROPERTY COMPILE_FLAGS " -Wno-sequence-point -Wno-cast-qual")
endif () endif ()
endif() endif()
if(lldb_lua_wrapper) if(LLDB_ENABLE_LUA)
add_dependencies(liblldb swig_wrapper_lua) add_dependencies(liblldb swig_wrapper_lua)
target_include_directories(liblldb PRIVATE ${LUA_INCLUDE_DIR}) target_include_directories(liblldb PRIVATE ${LUA_INCLUDE_DIR})
get_target_property(lldb_bindings_dir swig_wrapper_lua BINARY_DIR)
set(lldb_lua_wrapper ${lldb_bindings_dir}/LLDBWrapLua.cpp)
if (MSVC) if (MSVC)
set_property(SOURCE ${lldb_lua_wrapper} APPEND_STRING PROPERTY COMPILE_FLAGS " /W0") set_property(SOURCE ${lldb_lua_wrapper} APPEND_STRING PROPERTY COMPILE_FLAGS " /W0")
else() else()
set_property(SOURCE ${lldb_lua_wrapper} APPEND_STRING PROPERTY COMPILE_FLAGS " -w") set_property(SOURCE ${lldb_lua_wrapper} APPEND_STRING PROPERTY COMPILE_FLAGS " -w")
endif() endif()
set_source_files_properties(${lldb_lua_wrapper} PROPERTIES GENERATED ON) set_source_files_properties(${lldb_lua_wrapper} PROPERTIES GENERATED ON)
endif() endif()
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines