Page MenuHomePhabricator

Add -gdb-show and target-async option in -gdb-show command (MI)
ClosedPublic

Authored by ki.stfu on Mar 23 2015, 2:14 PM.

Details

Summary

This path adds -gdb-show command with 1 option: target-async.

Also it adds tests for -gdb-set and -gdb-show commands.

All tests pass on OS X.

Diff Detail

Event Timeline

ki.stfu updated this revision to Diff 22517.Mar 23 2015, 2:14 PM
ki.stfu retitled this revision from to Add -gdb-show and target-async option in -gdb-show command (MI).
ki.stfu updated this object.
ki.stfu edited the test plan for this revision. (Show Details)
ki.stfu added reviewers: abidh, clayborg.
ki.stfu added subscribers: abidh, clayborg, Unknown Object (MLST).

Friendly ping.

abidh accepted this revision.Mar 24 2015, 10:37 AM
abidh edited edge metadata.

I was wondering if there is a way to share code with -gdb-set command because there is a lot of similar code in these 2 command implementation. Otherwise ok.

tools/lldb-mi/MICmdCmdGdbShow.cpp
98

I think it will be useful to comment here that option can be a multi-word thing like "debug remote". So the first word is used to find the function and 2nd is used as argument to that function.

This revision is now accepted and ready to land.Mar 24 2015, 10:37 AM
clayborg accepted this revision.Mar 24 2015, 11:04 AM
clayborg edited edge metadata.

I will let MI experts handle this.

ki.stfu planned changes to this revision.Mar 24 2015, 1:43 PM
In D8566#146192, @abidh wrote:

I was wondering if there is a way to share code with -gdb-set command because there is a lot of similar code in these 2 command implementation. Otherwise ok.

Agree. But I don't know how to do that.

ki.stfu updated this revision to Diff 22600.Mar 24 2015, 2:14 PM
ki.stfu edited edge metadata.

Add a comment to CMICmdCmdGdbShow::Execute and CMICmdCmdGdbSet::Execute

This revision is now accepted and ready to land.Mar 24 2015, 2:14 PM
ki.stfu closed this revision.Mar 24 2015, 2:18 PM