This is an archive of the discontinued LLVM Phabricator instance.

clang/docs/CommandGuide/clang.rst
346	This is not a complete sentence (no predicate/verb), so from a grammar point of view, a period does not make sense. It seems like the other options use complete sentences (with a period). I'll reword this description to match the style of the other options (so a period will make sense).

tmfink mentioned this in D86426: [Docs] Fix --print-supported-cpus option rendering.Aug 23 2020, 8:15 PM

Fix rendering of --print-supported-cpus option and make alias documentation a
complete sentence.

tmfink marked an inline comment as done.Aug 23 2020, 8:19 PM

tmfink retitled this revision from [Docs] Link to --print-supported-cpus option to [Docs] Fix rendering for --print-supported-cpus option.

tmfink retitled this revision from [Docs] Fix rendering for --print-supported-cpus option to [Docs] Fix --print-supported-cpus option rendering.

tmfink edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B69269: Diff 287290.Aug 23 2020, 8:47 PM

nickdesaulniers accepted this revision.Aug 27 2020, 9:50 PM

This revision is now accepted and ready to land.Aug 27 2020, 9:50 PM

tmfink removed a reviewer: ziangwan.Sep 2 2020, 8:15 AM

@nickdesaulniers, could you merge my patch? I don't have commit access.
Thanks!

Closed by commit rG0fb2203cd6c2: [Docs] Fix --print-supported-cpus option rendering (authored by tmfink, committed by mehdi_amini). · Explain WhySep 12 2020, 10:26 PM

This revision was automatically updated to reflect the committed changes.

mehdi_amini added a commit: rG0fb2203cd6c2: [Docs] Fix --print-supported-cpus option rendering.

Revision Contents

Path

Size

clang/

docs/

CommandGuide/

clang.rst

6 lines

Diff 291441

clang/docs/CommandGuide/clang.rst

	Show First 20 Lines • Show All 332 Lines • ▼ Show 20 Lines
	.. option:: -miphoneos-version-min			.. option:: -miphoneos-version-min

	When building for iPhone OS, specify the minimum version supported by your			When building for iPhone OS, specify the minimum version supported by your
	application.			application.

	.. option:: --print-supported-cpus			.. option:: --print-supported-cpus

	Print out a list of supported processors for the given target (specified			Print out a list of supported processors for the given target (specified
	through --target=<architecture> or -arch <architecture>). If no target is			through ``--target=<architecture>`` or :option:`-arch` ``<architecture>``). If no
	specified, the system default target will be used.			target is specified, the system default target will be used.

	.. option:: -mcpu=?, -mtune=?			.. option:: -mcpu=?, -mtune=?

	Aliases of --print-supported-cpus			Acts as an alias for :option:`--print-supported-cpus`.
				nickdesaulniersUnsubmitted Done Reply Inline Actions Would you mind adding a `.` for punctuation while you're here? nickdesaulniers: Would you mind adding a `.` for punctuation while you're here?
				tmfinkAuthorUnsubmitted Done Reply Inline Actions This is not a complete sentence (no predicate/verb), so from a grammar point of view, a period does not make sense. It seems like the other options use complete sentences (with a period). I'll reword this description to match the style of the other options (so a period will make sense). tmfink: This is not a complete sentence (no predicate/verb), so from a grammar point of view, a period…

	.. option:: -march=<cpu>			.. option:: -march=<cpu>

	Specify that Clang should generate code for a specific processor family			Specify that Clang should generate code for a specific processor family
	member and later. For example, if you specify -march=i486, the compiler is			member and later. For example, if you specify -march=i486, the compiler is
	allowed to generate instructions that are valid on i486 and later processors,			allowed to generate instructions that are valid on i486 and later processors,
	but which may not exist on earlier ones.			but which may not exist on earlier ones.

	▲ Show 20 Lines • Show All 318 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[Docs] Fix --print-supported-cpus option renderingClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 291441

clang/docs/CommandGuide/clang.rst

[Docs] Fix --print-supported-cpus option rendering
ClosedPublic