Page MenuHomePhabricator

[NVPTX] Fix typo in lit test
ClosedPublic

Authored by ellis on Aug 7 2020, 4:38 PM.

Details

Reviewers
hiraditya
Summary

LBAEL => LABEL

I encountered this typo elsewhere and I decided to run a global search. It probably was unnoticed because I think CHECK-LBAEL: is ignored by lit.

Diff Detail

Event Timeline

ellis created this revision.Aug 7 2020, 4:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2020, 4:38 PM
ellis requested review of this revision.Aug 7 2020, 4:38 PM
ellis added inline comments.Aug 7 2020, 4:42 PM
llvm/test/CodeGen/NVPTX/combine-min-max.ll
128

Oh I didn't look at this closely, shouldn't these all be CHECK-LABEL: instead of just LABEL:?

ellis updated this revision to Diff 284094.Aug 7 2020, 4:59 PM

LABEL: => CHECK-LABEL:

hiraditya accepted this revision.Aug 7 2020, 5:10 PM
hiraditya added a reviewer: hiraditya.

LGTM. nice find!

This revision is now accepted and ready to land.Aug 7 2020, 5:11 PM
ellis added a comment.Aug 7 2020, 5:13 PM

@hiraditya would you mind landing this? I don't have commit access yet.

ellis updated this revision to Diff 284407.Aug 10 2020, 9:43 AM

Fix function name

ellis updated this revision to Diff 284410.Aug 10 2020, 9:45 AM

Fix label

ellis updated this revision to Diff 284435.Aug 10 2020, 10:38 AM

Fix more labels

ellis updated this revision to Diff 284448.Aug 10 2020, 10:54 AM

Sorry, I keep missing mismatched labels

ellis added a comment.Aug 10 2020, 6:53 PM

It looks like the tests pass now. @hiraditya could you land this?