This is an archive of the discontinued LLVM Phabricator instance.

[LLDB] Fix timeout value on expect_gdbremote_sequence
ClosedPublic

Authored by omjavaid on Aug 7 2020, 3:41 AM.

Details

Summary

D83904 seems to have changed timeout value on expect_gdbremote_sequence which was 120 previously. This seems to be causing intermittent failures on lldb-aarch64-ubuntu buildbot. This patch reverts the timeout value to its previous value to see the impact on test suite.

Example:
http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/7401/steps/test/logs/stdio

Diff Detail

Event Timeline

omjavaid created this revision.Aug 7 2020, 3:41 AM
omjavaid requested review of this revision.Aug 7 2020, 3:41 AM
JDevlieghere added inline comments.Aug 7 2020, 9:03 AM
lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
706

I see the problem, we're trying to process all the entries in the sequence in the timeout for a single packet. Rather than an arbitrary multiplier we should use the number of entries in the sequence. Let's define __len__ in GdbRemoteTestSequence

def __len__(self):
        return len(self.entries)

and then multiply the timeout by the length of the sequence:

self.DEFAULT_TIMEOUT * len(self.test_sequence)
omjavaid updated this revision to Diff 284068.Aug 7 2020, 3:00 PM

Fixed as suggested by @JDevlieghere

This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2020, 11:57 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2020, 11:57 AM