Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Make clang HIP headers compatible with C++98

Authored by scchan on Aug 6 2020, 12:56 PM.



Automation to detect compiler features, such as CMake's target_compile_features,
would attempt to detect compiler features by explicitly using langugage flags.
This change ensures that the HIP headers would still work with C++98.

Change-Id: I381f76fdaf42196d9272efeaa5a3a159edca0ab1

Diff Detail

Event Timeline

scchan created this revision.Aug 6 2020, 12:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2020, 12:56 PM
scchan requested review of this revision.Aug 6 2020, 12:56 PM
yaxunl accepted this revision.Aug 6 2020, 1:30 PM

LGTM. thanks

This revision is now accepted and ready to land.Aug 6 2020, 1:30 PM
This revision was landed with ongoing or failed builds.Aug 7 2020, 10:51 AM
This revision was automatically updated to reflect the committed changes.
arsenm added a subscriber: arsenm.Jun 19 2023, 4:16 AM

I don't understand why this is necessary. What does cmake have to do with it? Is HIP just not defaulting to the correct default C++ standard?

Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2023, 4:16 AM

Can you either

  1. Add test coverage
  2. Delete this entirely